d6859da3b4
render/vulkan: use _SRGB image view when possible
...
This is the last of a set of commits which ensures that both textures
and render buffers can be accessed through _UNORM and _SRGB image
views. While _UNORM image views are not yet used for 8-bpc image
formats, they will be needed in the future to support color transforms
for both textures and render buffers.
12 months ago
566c413d8f
render/vulkan: constify vulkan_format_props_find_modifier
12 months ago
88a4b9eefd
render/vulkan: create VkImage with option for _SRGB view, if possible
12 months ago
fd4548bb93
render/vulkan: detect which _UNORM formats support _SRGB views
12 months ago
acc70ee3a5
render/vulkan: extract shm texture format query into function
12 months ago
eab89d6c76
render/vulkan: track and use _UNORM variants of _SRGB formats
...
Later commits will start using _SRGB image views again,
where appropriate.
12 months ago
6e03d3015e
swapchain: Add wlr_swapchain_has_buffer
12 months ago
d3a339a03e
renderer: Drop buffer binding
12 months ago
3ed1268f64
render: Nuke old read pixels API
...
Sadly, the new API is not backwards compatible with the old API. Since
we have already switched all users in wlroots to the new API compositors
are already practically mandated to implement the new API. Let's get rid
of the old one since there is no point.
12 months ago
c5a3c5ca4c
render: Implement texture_preferred_read_format
12 months ago
57b18d26d0
wlr_texture: Introduce wlr_texture_preferred_read_format
12 months ago
09f16b2a9c
render/vulkan: Implement texture_read_pixels
12 months ago
e7055b4840
render/gles2: Implement texture_read_pixels
...
Also get rid of gles2_texture.owns_texture. We only use the tex/fbo
12 months ago
01bd098166
render/pixman: Implement texture_read_pixels
12 months ago
e85e8bc324
wlr_texture: Introduce wlr_texture_read_pixels_options helpers
12 months ago
4c6caa7c48
wlr_texture: Introduce wlr_texture_read_pixels
12 months ago
e8b187cc92
render/gles2: save/restore context when creating/submitting a render pass
...
This is useful for e.g. lazily blitting a texture for readback
purposes while rendering.
12 months ago
876d789ad5
render/gles2: reword wlr_gles2_texture comments
...
These comments were a bit misleading:
- "GL_TEXTURE_2D == mutable": not really, imported non-external-only
DMA-BUFs would also use this target, but are not mutable.
- "Only affects target == GL_TEXTURE_2D": same here.
- "If imported from a wlr_buffer": not really, would be NULL if
imported from a shm wlr_buffer.
Adjust these comments to better reflect reality and adjust the check
in gles2_texture_update_from_buffer().
12 months ago
84bef5c0c2
render/gles2: Inline texture invalidation
...
Let's us share more code with the other code path
12 months ago
9bf51e744e
render/gles2: Don't attach texture as buffer addon
...
Since wlr_gles2_buffer is now managing importing for us, there is
no reason for us to continue doing this.
12 months ago
829e34b305
render/gles2: Don't track image in texture
...
We can get it from the buffer
12 months ago
cb5f67431b
render/gles2: Don't double import dmabuf
...
We can double import a dmabuf if we use it as a texture target and
a render target. Instead, let's unify render targets and texture dmabuf
imports to use wlr_gles2_buffer which manages the EGLImageKHR
12 months ago
665055a1a0
render/gles2: Destroy textures first
...
Since imported textures will be based off of gles2_buffer we have
to destroy textures first or else they will have an invalid reference
to the buffers they are imported from.
12 months ago
484e248446
renderer/gles2: Bail rendering to external buffers when binding them
...
We can't do it while we're creating them because we'll want to use
gles2 buffers for textures soon.
12 months ago
0d9cd6932a
render/gles2: Lazily create buffer fbo
12 months ago
d7ecdad4e0
render: Drop rendering_with_buffer
...
This is always true now that we can only render with a buffer.
12 months ago
3faf9883dc
renderer: Drop wlr_renderer_begin
12 months ago
62b6c492d5
render/gles2: check external-only flag in get_or_create_buffer()
...
If the external-only flag is set, then the EGLImage is only
supported for use with GL_TEXTURE_EXTERNAL_OES texture targets.
In particular, the EGLImage cannot be bound to a RBO.
12 months ago
9118226634
render/gles2: Don't track has_alpha in pixel_format
...
Why track the alpha here when we can already get that information
elsewhere?
12 months ago
395a08f5d1
render/egl: fallback to GBM FD if EGLDevice is not available
...
It's possible that we don't have an EGLDevice if we created the
EGL context from a GBM device. Let's ensure all GPU-accelerated
renderers always have a DRM FD to return by falling back to GBM's
FD.
1 year ago
9a0a4ce221
render/vulkan: drop current_command_buffer
...
This was used by the legacy rendering API. Since begin()/end()
only need to set current_render_buffer and nothing else, we can
drop all of these bits.
1 year ago
56ec13596a
Cleanup wlr_matrix.h includes
...
Many files used to require wlr_matrix but no longer do.
1 year ago
9e702e9cfe
util/transform: move over wl_output_transform helpers
...
These aren't really tied to wlr_output.
1 year ago
41494244df
render: drop legacy rendering API
1 year ago
b2aac3390d
render/vulkan: drop legacy rendering API
1 year ago
514caea437
render/pixman: drop legacy rendering API
1 year ago
4635717d82
render/gles2: drop legacy rendering API
1 year ago
40633ae7fd
render: drop legacy render pass
...
All built-in renderers now implement the new API.
1 year ago
dbe7fb7027
render/vulkan: undo alpha premult for 8-bpc ARGB/ABGR
...
When a texel from the Vulkan format VK_FORMAT_B8G8R8A8_SRGB is read,
the sRGB to linear conversion is applied independently to the R, G,
and B channels; the A channel has no influence on this. However,
DRM_FORMAT_ARGB8888 buffers are, per Wayland protocol, not encoded
in this fashion; one must first unpremultiply the color channels
before doing sRGB to linear conversion. This commit switches to
handling ARGB8888 and ABGR8888 formats using the general fragment
shader conversion from electrical to optical values.
1 year ago
8ebfeffdc8
Remove unnecessary code
...
Not needs set GL_DEPTH_TEST, Because when rendering to a framebuffer
that has no depth buffer, depth testing always behaves as though
the test is disabled, The initial value for each capability with
the exception of GL_DITHER is GL_FALSE.
1 year ago
3232697252
render/vulkan: use VK_KHR_global_priority
...
References: #3386
1 year ago
1c2f608331
render/vulkan: remove unused queue_props in renderer
1 year ago
47bf87ade2
renderer/vulkan: don't add two alphas together in blend func
1 year ago
5adf325333
render/vulkan: undo alpha premult before sRGB encoding/decoding
...
sRGB encoding/decoding needs to happen with straight alpha, not
pre-multiplied alpha.
1 year ago
0b15b4a6ae
render/allocator: log message when GBM is disabled
...
When the backend and renderer would need GBM but it's disabled at
compile-time, log a message to make this situation easier to debug.
1 year ago
db7751f39e
render: log error when requested renderer is compile-time disabled
...
It can be a bit confusing to debug when the user requests an
explicit renderer but it's disabled at build-time. Log an error
when that happens.
1 year ago
e0adaaffb6
render/vulkan: constrain blend to output subpass to redrawn region
...
This commit only applies to the render pass API.
1 year ago
d817ebb80f
renderer: Don't crash when trying to fallback to pixman
...
Pixman won't be chosen by default if the system has a valid render node
but gles2 and vulkan creation failed.
1 year ago
4f92ecde82
renderer_autocreate_with_drm_fd: Ensure fd isn't bogus
1 year ago
1b0694b794
treewide: Migrate from sizeof(struct) to sizeof(*pointer) where practical
1 year ago
98a745d926
render/pass: Remove empty box early return
1 year ago
e9706e62f5
renderer: Use wlr_render_rect_options_get_box
...
Fixes : #3697
1 year ago
5299d973d5
render/pass: Introduce wlr_render_rect_options_get_box
1 year ago
5aea90264f
render/vulkan: fix validation error with vkCmdBlitImage
...
Specfically, VUID-vkCmdBlitImage-srcImage-00247.
1 year ago
65bbbbbf0c
render/vulkan: de-duplicate VkImageUsageFlags
...
The flags passed to vkCreateImage() must match the flags used when
querying formats. Make this clearer by using the same variable.
1 year ago
7bf6c1fc6c
render/pass: ensure rect has positive size
...
Ported from wlr_render_rect().
1 year ago
a94168b5fe
render: ensure wlr_render_rect_options->box is nonempty
...
This optimization also fixes an validation error with the Vulkan
renderer by ensuring vkCmdClearAttachments does not receive empty
regions.
1 year ago
11aba53ead
render: only open DRM render node if necessary
...
Only open a render node if we actually need one (ie, if we're about
to attempt GLES2 or Vulkan).
1 year ago
ce615a44c0
egl: Don't assume display is owned when KHR_display_reference is unsupported
...
We could potentially leak a display here, but not really because the
display acts as a singleton that will be returned next time a renderer
of the same device is created.
1 year ago
91a1797a96
egl: Remove dead code
...
Display is always NULL here since egl_init is always last to be called.
1 year ago
5f6912595e
renderer/vulkan: Defer device lost signal until end of pass
...
If the compositor were to try to handle a GPU reset within the lost
signal (by recreating the renderer) we should avoid referencing renderer
resources after the lost signal. This prevents use after free for such
compositors.
1 year ago
664ec59095
renderer: Sanity check texture source bounds
1 year ago
c74f89d4f8
Avoid using memcpy() to copy structs
...
We can just use a regular assignment instead. This is more
type-safe since there is no need to provide the struct size.
The remaining memcpy() calls perform array copies or copies from
void pointers (which may be unaligned).
1 year ago
061f5fafbd
render/vulkan: use renamed glslang binary by default
...
glslang 12.3.0 renamed glslangValidator to glslang,
use that by default and use the old name as a fallback.
References: https://github.com/KhronosGroup/glslang/blob/main/CHANGES.md?plain=1#L14
1 year ago
1205f03ec9
render/gles2: wrap timer setup in push_gles2_debug()
...
With this, errors should be properly wrapped in the debug scope.
1 year ago
b7dca21c2b
render: constify struct wlr_buffer_pass_options
...
Let's not allow renderer implementations to mutate the passed in
options.
1 year ago
fe06e5f49a
Use wl_container_of() instead of casts
...
This slightly improves type safety.
The culprits were found with:
git grep -E '\([a-z0-9_ ]+ \*\)\W?[a-z]'
1 year ago
c2c536de03
render/gles2: drop unnecessary cast
...
We can just refer to the struct field here.
1 year ago
7a9f8d8d6b
Use struct initializers instead of memset()
...
This is a bit more type-safe.
1 year ago
38d451bcb5
render/vulkan: Don't compute texture.has_alpha until first...
...
...texture view is dynamically created
1 year ago
06c0b0a204
render/vulkan: Initialize to fix compilation error
1 year ago
be73da28b2
allocator: only use DRM auth if we are master
...
Legacy DRM auth will only work if we are DRM master. Keep using an
unauthenticated DRM FD if we are not DRM master. This should be
enough for GBM.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3674
1 year ago
2044cc2311
render: Introduce wlr_render_texture_options.blend_mode
1 year ago
693005ac99
pixman: Remove dead code
1 year ago
6bd44c4fcd
renderer: Introduce wlr_scale_filter_mode
1 year ago
3ee0f52e09
render/vulkan: Dynamically create texture views
...
Now that we are dynamically creating pipeline layouts, we need separate
texture views for each pipeline layout we choose to use with a texture.
1 year ago
7c5a3afd60
render/vulkan: Inline init_sampler
1 year ago
8a387b5558
render/vulkan: Dynamically create pipeline layouts
...
These will happen lazily when pipelines get created.
1 year ago
3623005858
render/vulkan/pipeline_key: Add blending
...
This will become necessary when we switch away from scissoring. For the
time being, this cleans things up a bit and allows for a trivial
blending implementation for textures when that comes.
1 year ago
9d31372930
render/vulkan: Handle quad pipeline through generic pipeline path
1 year ago
97fdd57eb2
render/vulkan: Dynamically handle pipeline creation for textures
...
If we ever wanted to handle dynamic state that requires new pipelines
such as using different texture filters those can be added here with more
ease.
1 year ago
709c9dd287
render/vulkan: rename tex_usage to shm_tex_usage
...
Same motivation as fdb199a43c
1 year ago
30616bcf0c
render/vulkan: reset scissor before post-blend subpass
...
Otherwise only the last command's area will be copied over.
1 year ago
150a88bd03
render/vulkan: fix blend subpass matrix
...
renderer->render_{width,height} are unused with the render pass
API.
1 year ago
fd9e4b860f
render/vulkan: fix bound pipeline check for output_pipe
...
renderer->bound_pipe is legacy, pass->bound_pipeline is used for
the render pass API code-path.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3657
1 year ago
1b947c08c6
render/vulkan: require format info for shm
...
We use the format info to check the stride and need it to perform
the texture upload.
1 year ago
2a2f0772a9
render/vulkan: de-duplicate texture VkImageView init
...
The logic is the same for both shm and DMA-BUF.
1 year ago
cebe991e95
render/vulkan: split off YCbCr texture features
...
Avoids repeating the common bits between dma_tex_features and
dma_tex_ycbcr_features, and we will need just the YCbCr-related
flags for shm YCbCr support soon.
1 year ago
fdb199a43c
render/vulkan: rename tex_features to shm_tex_features
...
These features are required for shm only: the TRANSFER stuff is
for texture upload. We don't need these for DMA-BUFs. Make this
clearer by changing the name.
Also re-order the definitions to group all texture-related features
together.
1 year ago
398c6b66c6
render/gles2: Handle NULL timer
1 year ago
e0424b24f6
renderer: Don't pass NULL options
1 year ago
45ca284eee
render/gles2: implement timer API
1 year ago
9e8947e4d5
add render timer API
...
Based on five calls:
wlr_render_timer_create - creates a timer which can be reused across
frames on the same renderer
wlr_renderer_begin_buffer_pass - now takes a timer so that backends can
record when the rendering starts and finishes
wlr_render_timer_get_time - should be called as late as possible so that
queries can make their way back from the GPU
wlr_render_timer_destroy - self-explanatory
The timer is exposed as an opaque `struct wlr_render_timer` so that
backends can store whatever they want in there.
1 year ago
beb820b573
render/vulkan: improve error handling in vulkan_begin_render_pass()
...
Release the command buffer if we end up not submitting it.
2 years ago
0ba3ea3bcd
render/vulkan: improve error handling in render_pass_submit()
...
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3644
2 years ago
ba276e5ac2
render/vulkan: handle vulkan_record_stage_cb() failures
2 years ago
e07c77f846
render/vulkan: implement render pass API
2 years ago
8af00d5534
renderer/gles2: Implement render pass interface
2 years ago
b1d26ed47b
renderer/gles2: Compute texture coordinates based off of vertex positions
2 years ago
45b2a8eee2
renderer/gles2: Merge get_buffer and create_buffer
2 years ago
Manuel Stoeckl
Alexander Orzechowski
Simon Ser
JiDe Zhang
eri
Simon Zeni
Brett Ernst
q234rty
Rose Hudson