Alexander Orzechowski
d7ecdad4e0
render: Drop rendering_with_buffer
...
This is always true now that we can only render with a buffer.
12 months ago
Alexander Orzechowski
3faf9883dc
renderer: Drop wlr_renderer_begin
12 months ago
Simon Ser
62b6c492d5
render/gles2: check external-only flag in get_or_create_buffer()
...
If the external-only flag is set, then the EGLImage is only
supported for use with GL_TEXTURE_EXTERNAL_OES texture targets.
In particular, the EGLImage cannot be bound to a RBO.
12 months ago
Alexander Orzechowski
9118226634
render/gles2: Don't track has_alpha in pixel_format
...
Why track the alpha here when we can already get that information
elsewhere?
12 months ago
Simon Ser
395a08f5d1
render/egl: fallback to GBM FD if EGLDevice is not available
...
It's possible that we don't have an EGLDevice if we created the
EGL context from a GBM device. Let's ensure all GPU-accelerated
renderers always have a DRM FD to return by falling back to GBM's
FD.
1 year ago
Simon Ser
9a0a4ce221
render/vulkan: drop current_command_buffer
...
This was used by the legacy rendering API. Since begin()/end()
only need to set current_render_buffer and nothing else, we can
drop all of these bits.
1 year ago
Simon Ser
56ec13596a
Cleanup wlr_matrix.h includes
...
Many files used to require wlr_matrix but no longer do.
1 year ago
Simon Ser
9e702e9cfe
util/transform: move over wl_output_transform helpers
...
These aren't really tied to wlr_output.
1 year ago
Simon Ser
41494244df
render: drop legacy rendering API
1 year ago
Simon Ser
b2aac3390d
render/vulkan: drop legacy rendering API
1 year ago
Simon Ser
514caea437
render/pixman: drop legacy rendering API
1 year ago
Simon Ser
4635717d82
render/gles2: drop legacy rendering API
1 year ago
Simon Ser
40633ae7fd
render: drop legacy render pass
...
All built-in renderers now implement the new API.
1 year ago
Manuel Stoeckl
dbe7fb7027
render/vulkan: undo alpha premult for 8-bpc ARGB/ABGR
...
When a texel from the Vulkan format VK_FORMAT_B8G8R8A8_SRGB is read,
the sRGB to linear conversion is applied independently to the R, G,
and B channels; the A channel has no influence on this. However,
DRM_FORMAT_ARGB8888 buffers are, per Wayland protocol, not encoded
in this fashion; one must first unpremultiply the color channels
before doing sRGB to linear conversion. This commit switches to
handling ARGB8888 and ABGR8888 formats using the general fragment
shader conversion from electrical to optical values.
1 year ago
JiDe Zhang
8ebfeffdc8
Remove unnecessary code
...
Not needs set GL_DEPTH_TEST, Because when rendering to a framebuffer
that has no depth buffer, depth testing always behaves as though
the test is disabled, The initial value for each capability with
the exception of GL_DITHER is GL_FALSE.
1 year ago
eri
3232697252
render/vulkan: use VK_KHR_global_priority
...
References: #3386
1 year ago
Simon Zeni
1c2f608331
render/vulkan: remove unused queue_props in renderer
1 year ago
Brett Ernst
47bf87ade2
renderer/vulkan: don't add two alphas together in blend func
1 year ago
Simon Ser
5adf325333
render/vulkan: undo alpha premult before sRGB encoding/decoding
...
sRGB encoding/decoding needs to happen with straight alpha, not
pre-multiplied alpha.
1 year ago
Simon Ser
0b15b4a6ae
render/allocator: log message when GBM is disabled
...
When the backend and renderer would need GBM but it's disabled at
compile-time, log a message to make this situation easier to debug.
1 year ago
Simon Ser
db7751f39e
render: log error when requested renderer is compile-time disabled
...
It can be a bit confusing to debug when the user requests an
explicit renderer but it's disabled at build-time. Log an error
when that happens.
1 year ago
Manuel Stoeckl
e0adaaffb6
render/vulkan: constrain blend to output subpass to redrawn region
...
This commit only applies to the render pass API.
1 year ago
Alexander Orzechowski
d817ebb80f
renderer: Don't crash when trying to fallback to pixman
...
Pixman won't be chosen by default if the system has a valid render node
but gles2 and vulkan creation failed.
1 year ago
Alexander Orzechowski
4f92ecde82
renderer_autocreate_with_drm_fd: Ensure fd isn't bogus
1 year ago
Alexander Orzechowski
1b0694b794
treewide: Migrate from sizeof(struct) to sizeof(*pointer) where practical
1 year ago
Alexander Orzechowski
98a745d926
render/pass: Remove empty box early return
1 year ago
Alexander Orzechowski
e9706e62f5
renderer: Use wlr_render_rect_options_get_box
...
Fixes : #3697
1 year ago
Alexander Orzechowski
5299d973d5
render/pass: Introduce wlr_render_rect_options_get_box
1 year ago
Manuel Stoeckl
5aea90264f
render/vulkan: fix validation error with vkCmdBlitImage
...
Specfically, VUID-vkCmdBlitImage-srcImage-00247.
1 year ago
Simon Ser
65bbbbbf0c
render/vulkan: de-duplicate VkImageUsageFlags
...
The flags passed to vkCreateImage() must match the flags used when
querying formats. Make this clearer by using the same variable.
1 year ago
Simon Ser
7bf6c1fc6c
render/pass: ensure rect has positive size
...
Ported from wlr_render_rect().
1 year ago
Manuel Stoeckl
a94168b5fe
render: ensure wlr_render_rect_options->box is nonempty
...
This optimization also fixes an validation error with the Vulkan
renderer by ensuring vkCmdClearAttachments does not receive empty
regions.
1 year ago
Simon Ser
11aba53ead
render: only open DRM render node if necessary
...
Only open a render node if we actually need one (ie, if we're about
to attempt GLES2 or Vulkan).
1 year ago
Alexander Orzechowski
ce615a44c0
egl: Don't assume display is owned when KHR_display_reference is unsupported
...
We could potentially leak a display here, but not really because the
display acts as a singleton that will be returned next time a renderer
of the same device is created.
1 year ago
Alexander Orzechowski
91a1797a96
egl: Remove dead code
...
Display is always NULL here since egl_init is always last to be called.
1 year ago
Alexander Orzechowski
5f6912595e
renderer/vulkan: Defer device lost signal until end of pass
...
If the compositor were to try to handle a GPU reset within the lost
signal (by recreating the renderer) we should avoid referencing renderer
resources after the lost signal. This prevents use after free for such
compositors.
1 year ago
Alexander Orzechowski
664ec59095
renderer: Sanity check texture source bounds
1 year ago
Simon Ser
c74f89d4f8
Avoid using memcpy() to copy structs
...
We can just use a regular assignment instead. This is more
type-safe since there is no need to provide the struct size.
The remaining memcpy() calls perform array copies or copies from
void pointers (which may be unaligned).
1 year ago
q234rty
061f5fafbd
render/vulkan: use renamed glslang binary by default
...
glslang 12.3.0 renamed glslangValidator to glslang,
use that by default and use the old name as a fallback.
References: https://github.com/KhronosGroup/glslang/blob/main/CHANGES.md?plain=1#L14
1 year ago
Simon Ser
1205f03ec9
render/gles2: wrap timer setup in push_gles2_debug()
...
With this, errors should be properly wrapped in the debug scope.
1 year ago
Simon Ser
b7dca21c2b
render: constify struct wlr_buffer_pass_options
...
Let's not allow renderer implementations to mutate the passed in
options.
1 year ago
Simon Ser
fe06e5f49a
Use wl_container_of() instead of casts
...
This slightly improves type safety.
The culprits were found with:
git grep -E '\([a-z0-9_ ]+ \*\)\W?[a-z]'
1 year ago
Simon Ser
c2c536de03
render/gles2: drop unnecessary cast
...
We can just refer to the struct field here.
1 year ago
Simon Ser
7a9f8d8d6b
Use struct initializers instead of memset()
...
This is a bit more type-safe.
1 year ago
Alexander Orzechowski
38d451bcb5
render/vulkan: Don't compute texture.has_alpha until first...
...
...texture view is dynamically created
1 year ago
Alexander Orzechowski
06c0b0a204
render/vulkan: Initialize to fix compilation error
1 year ago
Simon Ser
be73da28b2
allocator: only use DRM auth if we are master
...
Legacy DRM auth will only work if we are DRM master. Keep using an
unauthenticated DRM FD if we are not DRM master. This should be
enough for GBM.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3674
1 year ago
Alexander Orzechowski
2044cc2311
render: Introduce wlr_render_texture_options.blend_mode
1 year ago
Alexander Orzechowski
693005ac99
pixman: Remove dead code
1 year ago
Alexander Orzechowski
6bd44c4fcd
renderer: Introduce wlr_scale_filter_mode
1 year ago