47c7674a68
Merge pull request #1075 from emersion/fix-xdg-toplevel-compare
...
xdg-shell{,-v6}: fix compare_xdg_surface_toplevel_state
7 years ago
a59774f364
xdg-shell{,-v6}: fix compare_xdg_surface_toplevel_state
7 years ago
a6c0e25d36
surface: remove wlr_frame_callback
...
This removes the need to allocate a structure for frame callbacks.
wl_resource_get_link is used instead.
7 years ago
57548b557a
Merge branch 'master' into screencontent
7 years ago
bd0c1b7949
export-dmabuf: update protocol
7 years ago
843621714f
surface: fix double wl_buffer.release events
...
Prior to this commit, we re-uploaded the buffer even if a new one
wasn't attached. After uploading, we send wl_buffer.release. So,
this sequence of requests resulted in a double release:
surface.attach(buffer, 0, 0)
surface.commit()
<- buffer.release()
surface.commit()
<- buffer.release()
7 years ago
fb118ac996
Merge pull request #1062 from emersion/wlr-buffer-comeback
...
Add back wlr_buffer
7 years ago
225aa815b0
buffer: fix wlr_texture leak on failed alloc
7 years ago
23707f6504
layer-shell: check whether the surface is mapped in layer_surface_destroy()
...
If the layer surface has been closed by the compositor, using
layer_surface_close(), then the unmap event is emitted. However, when
the layer surface is later destroyed by the client, the compositor used
to get a second unmap, which is fixed with this commit.
7 years ago
da114d5013
buffer: don't destroy DMA-BUF textures with wl_buffer
...
After some discussions on #wayland, it seems that as soon as you
hold a reference to a DMA-BUF (via EGLImage for instance), the
underlying memory won't get free'd. The client is allowed to
re-use the DMA-BUF and upload something else to it though.
7 years ago
d27eeaa14c
Revert "Merge pull request #1050 from emersion/wlr-buffer"
...
This reverts commit 5e4af4862e9a1f0e2d5f
7 years ago
0378d143d9
surface: remove wlr_surface.texture
...
The texture is managed by the surface's wlr_buffer now. In
particular, the buffer can destroy the texture early if it becomes
invalid.
7 years ago
38d415dd20
buffer: make wlr_buffer_ref return the buffer
7 years ago
e4933ab445
Introduce wlr_buffer
7 years ago
6f895081e1
Merge pull request #1043 from acrisci/drag-icon-unmap
...
drag-icon map and unmap fixes
7 years ago
211463ba87
Merge pull request #1045 from ammen99/master
...
xdg-shells: add a set_parent signal to toplevel surfaces
7 years ago
1a07bf95ae
Merge pull request #1044 from emersion/fix-box-intersection
...
box: fix wlr_box_intersection
7 years ago
a989104a6b
xdg-shells: add a set_parent signal to toplevel surfaces
7 years ago
ed89a24328
box: fix wlr_box_intersection
7 years ago
7c888a39c6
update drag position at the right times
7 years ago
319ebdf476
add back map event
7 years ago
1c75d4e54a
rename drag-icon map to unmap
7 years ago
c6821f3dd3
wlr_surface: insert subsurfaces in revert order
...
sibling surfaces were drawn in incorrect order (e.g. latest below).
This attempts to fix that by reverting the order of the list.
7 years ago
7206997e95
fix wlr_box_intersection and closest_point
7 years ago
a57d1baf57
Merge pull request #1033 from RyanDwyer/fix-xdg-popups
...
Fix mistakes in xdg_popup and xdg_popup_v6
7 years ago
344374fa14
Merge pull request #1039 from acrisci/positioner-invert-x-fix
...
add missing anchor case in positioner invert-x for xdg-shell
7 years ago
bcb660cb1d
add missing anchor case in positioner invert-x
7 years ago
78966417f4
Merge pull request #1031 from martinetd/multibind-seat
...
seat: allow clients to bind to seat multiple times
7 years ago
cf9b8c0a8c
wlr_surface_get_root_surface: walk up parent
...
This would dead-loop and never walk up if called on a subsurface
7 years ago
51b9883ea0
seat: allow clients to bind to seat multiple times
...
This lets clients bind to a seat multiple times by re-using the existing
wlr_seat_client whenever a duplicate request happens.
Previously, an independant wlr_seat_client would be created and only
events from one would be processed.
Fixes #1023 .
7 years ago
eb8b8acca6
wlr_linux_dmabuf: Fix printf conversion specifiers on armhf
...
The printf conversion specifiers in a call to wl_resource_post_error
do not specify the type correctly on armhf:
../types/wlr_linux_dmabuf.c: In function 'params_add':
../types/wlr_linux_dmabuf.c:104:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
"sent modifier %lu for plane %u, expected modifier %lu like other planes",
~~^
%llu
To fix this, we use standard printf conversion specifier macros from
inttypes.h.
7 years ago
516c864d46
Fix mistakes in xdg_popup and xdg_popup_v6
7 years ago
7b07b3f95d
Fix type in wlr_surface_get_extends
7 years ago
3994762ae0
Add wlr_surface_get_geometry
...
This function defaults and clips the xdg-surface geometry to the
bounding box of the surface + its subsurfaces, as specified by the
protocol spec.
7 years ago
6b7a55aa3d
Merge pull request #1020 from emersion/remove-check-dmabuf
...
render: remove wlr_renderer_check_import_dmabuf
7 years ago
21928cbe61
Merge branch 'master' into screencontent
7 years ago
d1cf9acbd5
cleanup: Use void for zero-parameter functions
...
Signed-off-by: Genki Sky <sky@genki.is>
7 years ago
f90b024ad0
linux-dmabuf: fix bound checks for stride and height
...
- Fix bound checking for offset + stride * height
- Make offset bound checking more consistent
- Reject zero strides
7 years ago
135721118a
render: remove wlr_renderer_check_import_dmabuf
...
It's possible to implement it outside the renderer, by creating a
texture and destroying it right away. This reduces the API surface
of the renderer.
7 years ago
41e53d1499
Merge pull request #1019 from emersion/virtual-keyboard-destroy
...
virtual-keyboard: fix wlr_virtual_keyboard_manager_v1_destroy
7 years ago
28020ff577
Only allow one modifier per DMA-BUF, split attributes struct in render/
7 years ago
f580112dca
virtual-keyboard: fix wlr_virtual_keyboard_manager_v1_destroy
7 years ago
87fe9f3466
Merge pull request #1014 from RyanDwyer/fix-wlr-box-contains-point
...
Fix wlr_box_contains_point comparison
7 years ago
2681352e04
export-dmabuf: permanently fail if backend doesn't implement export_dmabuf
7 years ago
a16ad4327a
Update protocol
7 years ago
65198b0aab
export-dmabuf: assert number of planes
7 years ago
2432c41a49
export-dmabuf: correctly send the number of planes per layer
7 years ago
3f9796112e
export-dmabuf: fix tv_sec_hi
7 years ago
00e108f2fc
export-dmabuf: correctly finish wlr_linux_dmabuf_attribs
7 years ago
1377e551ef
Update wlr-export-dmabuf protocol
7 years ago
e26f4dff98
export-dmabuf: wait for the frame to be ready, send timestamp
7 years ago
36bd4795d4
export-dmabuf: add basic and incomplete implementation
7 years ago
9e26808c28
output, backend/drm: add wlr_output_export_dmabuf
7 years ago
e1f56538a8
Merge pull request #999 from dcz-purism/virtual-keyboard
...
Support virtual keyboard protocol
7 years ago
f8a831859f
Fix wlr_box_contains_point comparison
7 years ago
5334ee8bfd
virtual-keyboard: add support for the virtual-keyboard-v1 protocol
7 years ago
47f097e09b
xdg-shell: add wlr_xdg_toplevel_set_tiled
7 years ago
da504f9253
surface: remove wl_resource_post_event
7 years ago
e849a68e6e
output: correctly clear screen when fullscreened
7 years ago
98088e78df
Merge pull request #977 from emersion/split-xdg-shell
...
Split xdg-shell into multiple files
7 years ago
c74f5b1138
xdg-output: bump output manager version to 2
7 years ago
63fd2203fe
Add support for version 2 of the xdg-output protocol
7 years ago
dbba1311b7
output: fix lingering hardware cursors
7 years ago
3036507463
xdg-shell: split into multiple files
7 years ago
c7480d5084
xdg-shell-v6: rename shared private functions to prevent conflicts with xdg-shell stable
7 years ago
facc5aa359
xdg-shell-v6: split into separate files
7 years ago
cc12d03545
xdg-shell: fix positioner
...
The anchor and gravity bitfields in xdg-shell-unstable-v6 have
been changed to a plain enum whose values cannot be used as a
bitfield in xdg-shell. While it makes input validation easier, it
also makes positioner operations a pain in the ass.
7 years ago
b28f06eca0
Don't use unsafe casts in wlr_xdg_popup_get_toplevel_coords
7 years ago
7a952dfa2d
xdg-output: fix logical_size
...
It should be the size of the output in layout coordinates. Prior to
this commit we were not applying the output transform to the size.
7 years ago
db84379242
Send axis source event
7 years ago
0b58579564
Add support for discrete axis values
7 years ago
cf5013416d
xdg-output: redesign resource destroy
7 years ago
13098a18ea
Fix hardware cursors scale & transform
7 years ago
8931452e1d
add wlr_layer_surface_surface_at
...
Adds wlr_layer_surface_surface_at, this is consistent with the other
shell implementations, and simplifies handling in compositors.
7 years ago
5087199d5d
output-damage: limit the number of damaged rectangles
7 years ago
caf9f9022c
Merge pull request #936 from emersion/full-hardware-cursors
...
output: always use hardware cursors if available
7 years ago
2959fcce1a
Merge pull request #951 from chebykinn/fix-maybe-uninitialized
...
Fix gcc maybe-uninitialized in wlr_cursor apply_output_transform
7 years ago
57d03a3eda
Merge pull request #931 from emersion/redesign-resource-destroy
...
Redesign resource destruction
7 years ago
cec7cd2b39
Fix gcc maybe-uninitialized in wlr_cursor apply_output_transform
7 years ago
d136026a2c
seat: implement inert seat resources
7 years ago
6305e6327f
Fix typos in comments and strings
7 years ago
5d37b14116
data-device: make sure resources are correctly destroyed
7 years ago
7843a48432
output: simplify and update code style
7 years ago
ff4708d406
linux-dmabuf: correctly destroy resources
7 years ago
6d569def6d
compositor, surface: correctly destroy resources
7 years ago
2964248f42
Merge pull request #935 from agx/cursor-output-transform
...
wlr_cursor: transform absolute coordinates
7 years ago
2cff6dbd63
seat: split into multiple files
7 years ago
4b5b02057c
Merge pull request #937 from emersion/reorder-data-device
...
data-device: split into multiple files
7 years ago
4efae8c177
wlr_cursor: transform absolute coordinates
...
Honor output rotation when processing absolute coordinates. This fixes
touch events on rotated outputs.
Fixes #928
7 years ago
1e563e7ecf
data-device: split into multiple files
7 years ago
6b3eac37f1
output: assert move_cursor if set_cursor is available
7 years ago
8f5045c871
Silently ignore touch_{motion,up} for unknown ids
7 years ago
225d182765
output: always use hardware cursors if available
...
This changes the `wlr_output_impl.set_cursor` function to take a
`wlr_texture` instead of a byte buffer. This simplifies the
DRM and Wayland backends since they were creating textures from
the byte buffer anyway.
With this commit, performance should be improved when moving the
cursor since outputs don't need to be re-rendered anymore.
7 years ago
2551ef8871
input-device: add output_name field, populate it from libinput
7 years ago
a0f4903063
Merge pull request #926 from emersion/fix-x11-backend-memory-leaks
...
Fix some backend memory leaks
7 years ago
f8e0a03451
backend/x11: correctly destroy input devices
7 years ago
79da4c175e
backend/headless: remove useless destructor
7 years ago
6e7c0b57f6
cursor: use NAN for unspecified axes, refactor absolute warping code
7 years ago
126f12e428
xdg-shell: fix invalid xdg-positioner cast
7 years ago
43012f3740
compositor: redesign how resources are managed
...
All public resource creators now take a new ID for the resource
and an optional list where the resource link is added. When the
resource is destroyed it is its own responsibility to remove
itself from the list. This removes the need for the caller to add
a destroy listener.
This commit fixes a few segfaults with resources not removed from
the list when destroyed.
7 years ago
979b1b22d5
Merge pull request #914 from emersion/misc-segfault-fixes
...
Misc segfault fixes
7 years ago
874909dca6
xdg-shell: fix invalid wlr_xdg_positioner alloc
7 years ago
fcb7ad925d
layer-shell: fix use-after-free when client requests an invalid layer
7 years ago
93ebd33aa8
Merge pull request #890 from agx/layer-shell-empty-output-crash
...
layer-shell: Fix crash when cursor is intially outside any output
7 years ago
d81f0170a3
layer-shell: Don't crash when the compositor didn't find a suitable output
...
In that case it must have closed the surface.
7 years ago
fecb971518
Merge pull request #902 from emersion/various-memory-leaks
...
Various memory leaks
7 years ago
449f06556a
Destroy wlr_surface with wlr_renderer
7 years ago
d47713ac0f
compositor: destroy subsurface resources with wlr_subcompositor
7 years ago
89a9c96fab
compositor: make wlr_compositor_destroy destroy resources
7 years ago
625a7a48dc
Don't use the wlr_ prefix for static functions
7 years ago
b0d99f5c67
Remove wlr_ prefix from local symbols
7 years ago
8e2f3056f8
layer-shell: fix small memory leak
7 years ago
bc0bfde5ee
cursor: allow to call wlr_cursor_wrap_absolute with zero
7 years ago
38064f1d18
Fix protocol error when a client destroys and re-creates a subsurface
7 years ago
941f88ce23
Fix popup positioning & double popups
7 years ago
52baf3dd8a
Move get_geometry call back to xdg-shell
7 years ago
0a0627f5d0
Finish forward-porting @acrisci's positioner work
7 years ago
2e3d901ac5
Forward-port xdg-shell-v6 positioner improvements
7 years ago
278aa84619
Basic layer popup rendering
7 years ago
d3cdb00208
Add (shitty) support for popups to layer example
7 years ago
6b7b64ec1e
Generalize xdg-shell popups and add to layer-shell
7 years ago
625bc7b8b3
assert(surface->output); after new_surface emit
7 years ago
177b548b15
Update layer shell with optional wl_output
7 years ago
3bce5dfc9f
Fix segfaults in wlr_surface_is_*
7 years ago
bfcd3f3707
Add wlr_subcompositor
7 years ago
fa84b267e0
Remove wlr_surface::subsurface
7 years ago
c8ccb1bef3
reorder xkb state handling in wlr_keyboard
...
wlr_keyboard manages the xkb-common state of the compositor.
It used to update the state, update the modifiers, then notify the
compositor.
When [Shift_L] was pressed and released, this resulted in an event chain:
Modifiers: Shift
Key: Shift_L (Pressed)
Modifiers:
Key: Shift_L (Release)
The xkb-docs state that the state should be updated *after* the key was
handled [1], to prevent the new state from influencing the actual key
generated.
To achieve this, the event to the compositor is emitted, *before*
wlroots handles the xkb and internal keyboard state.
With this patch applied, the emitted events ill be:
Modifiers:
Key: Shift_L (Pressed)
Modifiers: Shift
Key: Shift_L (Release)
[1] https://xkbcommon.org/doc/current/group__state.html#gac554aa20743a621692c1a744a05e06ce
7 years ago
94fa6c88f4
output: don't emit the mode event if it hasn't changed
...
This also fixes #535 .
7 years ago
1b802d9251
Make wlr_renderer_scissor take normal coords instead of upside-down ones
7 years ago
8f4039d799
Merge pull request #861 from emersion/fix-output-transform-compose
...
Fix wlr_output_transform_compose
7 years ago
31c8bdc277
Fix wlr_output_transform_compose
7 years ago
fa0be972bb
Fix wlr_xdg_surface_surface_at for popups
7 years ago
bef5c1fd56
Merge pull request #850 from emersion/remove-backend-egl
...
backend: remove wlr_backend_get_egl
7 years ago
d2ebbd103c
backend: remove wlr_backend_get_egl
7 years ago
bf68854a38
Fix destruction of popups without grabs
...
Fixes #846
7 years ago
ae4cef9e41
Merge pull request #825 from emersion/surface-iterators
...
Add surface iterators
7 years ago
ec0ce8ae1c
Fix sending updates to xdg-output resources
...
Fixes #836
7 years ago
6710de9878
Merge branch 'master' into xwayland-dnd
7 years ago
4a9a9eae9a
Add surface iterators
7 years ago
19b576734e
Merge pull request #834 from emersion/surface-is-subsurface
...
Add wlr_surface_is_subsurface and wlr_subsurface_from_surface
7 years ago
aced024819
Add wlr_surface_is_subsurface and wlr_subsurface_from_surface
7 years ago
abfe7923c4
Add wlr_xdg_output_manager
7 years ago
3ea425d4e2
Fix xdg-shell popups, add wlr_xdg_surface_surface_at
7 years ago
c9d21106b4
Add wlr_xdg_surface_v6_surface_at and wlr_wl_shell_surface_surface_at
7 years ago
1a8b24bdd2
rootston: fix view_at
7 years ago
d16127b3cb
Fix wlr_surface_subsurface_at, change it to be wlr_surface_surface_at
7 years ago
36e94b2a8e
Actually fix input inhibitor destructor
7 years ago
1fa3ca3152
Revert "Add destructor to inhibitor"
...
This breaks shit
This reverts commit 657d2c9a69
7 years ago
657d2c9a69
Add destructor to inhibitor
7 years ago
ef4e833f13
Add wlr_input_inhibitor
7 years ago
58ac05c276
Merge branch 'master' into xwayland-dnd
7 years ago
333ab59902
Add wlr_surface_is_*_surface
...
And wlr_*_surface_from_wlr_surface
7 years ago
8836b4f024
Merge branch 'master' into xwayland-dnd
7 years ago
5a47da1ea6
annotate wlr-output-layout coord variables
7 years ago
1778818a50
Don't destroying all layer surfaces on client d/c
7 years ago
e19ee6d469
Add wlr_surface_point_accepts_input
...
Ref https://github.com/swaywm/sway/pull/1674
7 years ago
6bbf507082
surface: fix texture not updated on commit
...
When a client attaches a wl_drm or a linux_dmabuf buffer, we only
update it if the size is different from the one of the old buffer.
This means that if the client attaches a new, updated buffer with
the same size as the old buffer, the texture won't get updated.
This commit changes this behavior and re-creates the texture if
the client attaches a new buffer, without requiring the size to be
different.
7 years ago
d5f46f4db4
data-device: redesign wlr_data_source
7 years ago
4137d9fc80
Destroy layer surfaces on client destroyed
7 years ago
743466d475
data-device: add seat.drag_source
7 years ago
a316396eab
Merge pull request #720 from acrisci/xdg-positioner
...
xdg-positioner
7 years ago
2e63d1a0ca
toplevel_box to toplevel_sx_box
7 years ago
cf13a6d9c6
address toplevel coords issue
7 years ago
967bccffcd
remove xdg-positioner wlr wrappers
7 years ago
8b967fc573
bug: dont slide over too far
7 years ago
bf5ae85683
return early when no dest_x/y in output layout closest point
7 years ago
bd828e23de
dont allocate xdg-positioner attrs
7 years ago
376d1cc0da
rename xdg-positioner structs
7 years ago
3effe153bc
xwayland: make wayland → xwayland work
7 years ago
4ab88a5330
xdg-positioner bugfix
7 years ago
0bfcce50a9
xdg-positioner: honor constraint flags
7 years ago
dbffda7549
xdg-positioner wlr abstractions
7 years ago
2a34b154e6
xwayland: send DND_DROP
7 years ago
73394deb76
xwayland: send DND_POSITION
7 years ago
0d7a81ccdf
xwayland: send DND_ENTER
7 years ago
324b9d910d
Remove width_mm from wlr_touch events
7 years ago
a35a5786b0
Remove width_mm from wlr_pointer events
7 years ago
41e54ba632
Merge branch 'master' into xdg-positioner
7 years ago
330ee08126
Merge pull request #744 from emersion/texture-redesign
...
Redesign wlr_texture
7 years ago
7d89e7e58d
Assign layer surface role
7 years ago
96a8df2f9a
Fix ack configure/configure flow
...
Prevents FOUC/improves frame perfect rendering goal
7 years ago
52fe2688ea
Address @emersion's feedback
7 years ago
e841e5602b
Address @emersion's feedback
7 years ago
86ca4bea6d
Fix layer rendering/layout bugs
7 years ago
d1c0e6fe2c
Add layer_surface.close
7 years ago
4bf936360d
Arrange & render layer surfaces
7 years ago
fcf8c6c8a2
Fix issues preventing layer from getting allocated
...
Now all of the steps to get rootston a reference to the layer surface
are correctly wired up.
7 years ago
88eec637a4
Address feedback
7 years ago
1628730b09
Add wlr_layer_surface_configure
7 years ago
4a8c0c0784
Destroy layer surfaces when client is destroyed
7 years ago
b06105b564
Implement layer surface requests
7 years ago
3ba57fccd1
Wire up layer surface resources to stubs
7 years ago
f29d8b55ae
Initial scaffolding of layer shell
7 years ago
8371e2f41d
implement flip_x
7 years ago
171e28eaff
xdg-shell: don't destroy role resources on unmap, move toplevel fields
...
Ports 5233801530334bab543d
7 years ago
bbd0e23fa7
xdg-positioner constraint detection
7 years ago
334bab543d
xdg-shell-v6: move toplevel specific fields in wlr_xdg_toplevel_v6
7 years ago
adf4fb08dd
Merge branch 'master' into texture-redesign
7 years ago
5233801530
xdg-shell-v6: don't destroy role resources on unmap
...
The motivation for this is:
- `get_popup` and `get_toplevel` allocate role-specific resources.
- On the first non-null commit, the surface gets mapped.
- On a null commit, the surface gets unmapped. It can be mapped
again with a non-null commit.
- When the role object (xdg-toplevel or xdg-popup) is
destroyed, the surface is unmapped and role-specific resources
are destroyed. The client can call `get_popup` or `get_toplevel`
again on that surface.
- When the xdg-surface object is destroyed, the surface is
unmapped, role-specific resources are destroyed and the surface
itself is destroyed.
7 years ago
4da18f7fc3
xdg-positioner attrs
7 years ago
Drew DeVault
emersion
Ilia Bozhinov
Tony Crisci
Dominique Martinet
Bob Ham
Ryan Dwyer
Markus Ongyerth
Genki Sky
Dorota Czaplejewicz
Ivan Chebykin
morganamilo
Guido Günther