compositor: remove wlr_surface_role.precommit

It was previously used to handle unmapping properly but is obsolete now.

include/wlr/types/wlr_compositor.h

@@ -74,8 +74,6 @@ struct wlr_surface_state {
 struct wlr_surface_role {
 	const char *name;
 	void (*commit)(struct wlr_surface *surface);
-	void (*precommit)(struct wlr_surface *surface,
-		const struct wlr_surface_state *state);
 	void (*unmap)(struct wlr_surface *surface);
 	void (*destroy)(struct wlr_surface *surface);
 };

types/wlr_compositor.c

@@ -434,10 +434,6 @@ static void surface_commit_state(struct wlr_surface *surface,
 		struct wlr_surface_state *next) {
 	assert(next->cached_state_locks == 0);
 
-	if (surface->role_data != NULL && surface->role->precommit != NULL) {
-		surface->role->precommit(surface, next);
-	}
-
 	wl_signal_emit_mutable(&surface->events.precommit, next);
 
 	bool invalid_buffer = next->committed & WLR_SURFACE_STATE_BUFFER;