xdg_popup: fix call to to handle_grab for inert popup

7 years ago · a3e2a77734
parent 970687a01c
commit a3e2a77734
2 changed files with 6 additions and 0 deletions
--- a/types/xdg_shell/wlr_xdg_popup.c
+++ b/types/xdg_shell/wlr_xdg_popup.c
@ -152,6 +152,9 @@ static void xdg_popup_handle_grab(struct wl_client *client,
 		wlr_xdg_surface_from_popup_resource(resource);
 	struct wlr_seat_client *seat_client =
 		wlr_seat_client_from_resource(seat_resource);
+	if (!surface) {
+		return;
+	}

 	if (surface->popup->committed) {
 		wl_resource_post_error(surface->popup->resource,
--- a/types/xdg_shell_v6/wlr_xdg_popup_v6.c
+++ b/types/xdg_shell_v6/wlr_xdg_popup_v6.c
@ -174,6 +174,9 @@ static void xdg_popup_handle_grab(struct wl_client *client,
 		xdg_surface_from_xdg_popup_resource(resource);
 	struct wlr_seat_client *seat_client =
 		wlr_seat_client_from_resource(seat_resource);
+	if (!surface) {
+		return;
+	}

 	if (surface->popup->committed) {
 		wl_resource_post_error(surface->popup->resource,