8533c35a9f
Fix crash and render issues involving cursor_send_pointer_motion
...
Fixes #2303 , as well as a crash.
To replicate the crash:
* Have multiple outputs
* In config: for_window [<criteria>] workspace foo
* Also in config: workspace foo output <left-output-name>
* Focus the right output, and ensure workspace foo doesn't exist
* Launch the app that triggers the criteria
When the view maps, it calls workspace_switch which calls
send_set_focus which calls cursor_send_pointer_motion which calls
transaction_commit_dirty. This call to transaction_commit_dirty is not
meant to happen at this time because the tree isn't guaranteed to be in
a consistent state, but I'm not sure how exactly this leads to the crash
or render issues.
In this case the transaction is already committed by the view
implementation's handle_map function. So the solution is to remove it
from cursor_send_pointer_motion and add it to the other functions in
cursor.c which call cursor_send_pointer_motion.
6 years ago
dfb45ded1c
Merge pull request #2306 from RyanDwyer/move-workspace-crash
...
Fix crash when moving workspace to output
6 years ago
dad3a8deee
Fix crash when moving workspace to output
6 years ago
08736255a3
Defer the focus commands
6 years ago
a173b79c54
Implement focus output command
6 years ago
ec65286606
Fix deferred command handling
6 years ago
4931d0ddc5
Merge pull request #2300 from emersion/override-redirect-updates
...
Handle xwayland override_redirect flag change
6 years ago
747725b8bb
Don't unfocus when an override redirect window is mapped
6 years ago
fb4eca5d56
Handle xwayland override_redirect flag change
...
This fixes syncplay menus.
6 years ago
ca695482ec
Merge pull request #2292 from emersion/update-cursor-on-focus
...
Update cursor on focus change
6 years ago
81e4bbf8b2
Merge pull request #2294 from RedSoxFan/fix-swaylock-args
...
Fix swaylock arguments
6 years ago
7885a138af
Fix swaylock arguments
6 years ago
5903fb4640
Merge pull request #2229 from vilhalmer/destroy-output-destroy-empty-workspaces
...
Destroy empty workspace when destroying its output
6 years ago
8ce7e3b44e
Merge branch 'master' into destroy-output-destroy-empty-workspaces
6 years ago
48b911a459
Merge pull request #2281 from pvsr/X11_click
...
Send clicks to swaybar blocks as X11 button ids
6 years ago
e43c20134a
remove unnecessary parens
6 years ago
03d49490cc
Update cursor on focus change
...
This allows to send wl_pointer.enter when switching between views
in a split/tabbed layout for instance. This (1) updates the cursor
image accordingly (2) makes it unnecessary to move the mouse before
scrolling. It's harmless to always call cursor_send_pointer_motion
because in case the focused surface hasn't changed this is a no-op.
The `last_focus != NULL` condition is required otherwise
cursor_send_pointer_motion will crash when sway starts up (the
sway_output doesn't yet have a workspace).
6 years ago
bec982bba6
Merge pull request #2289 from frsfnrrg/memory-fixes
...
Fix memory leaks and reference to uninitialized
6 years ago
3931cb85b2
Fix memory leak in sway/desktop/idle_inhibit_v1.c
6 years ago
37471ac649
Fix memory leak in handle_layer_shell_surface
6 years ago
600676688a
Free individual criteria in free_config
...
Also free cmd_list when cleaning up a struct criteria.
6 years ago
b3014f7b16
Fix uninitialized pointer in view_unmap
...
Otherwise, sway crashes due to uninitialized pointer
dereference when AddressSanitizer is active.
6 years ago
f516dbfb6d
Merge pull request #2286 from RyanDwyer/default-floating-border
...
Implement default_floating_border command and adjust CSD behaviour
6 years ago
10fc7a5b49
Merge branch 'master' into default-floating-border
6 years ago
db3a363734
Revert "config: free include path on successful load"
...
This reverts commit 92450883d7
6 years ago
9c8d73dad6
Merge pull request #2287 from RyanDwyer/superfluous-urgent-events
...
Remove superfluous IPC urgent events
6 years ago
9cbff272cb
Remove superfluous IPC urgent events
...
When an xwayland view is mapped, the IPC urgent event was being sent on
every surface commit.
I had intentionally ommitted the check because I figured an urgent
surface could update its urgent timestamp by sending urgent a second
time. But that's not how it works in xwayland's case, and it makes for
more complicated code.
6 years ago
75c699db62
Implement default_floating_border command and adjust CSD behaviour
6 years ago
7268d544c2
Merge pull request #2285 from emersion/cleanup-swayidle
...
swayidle: cleanup
6 years ago
14511da75d
send scroll events to swaybar blocks
6 years ago
79a998849b
make hotspot callback take an x11 button id
6 years ago
d6bd314dff
Merge pull request #2276 from RyanDwyer/urgency
...
Implement urgency base functionality
6 years ago
255dc8bbb0
swaybar: Read urgent colors from IPC
6 years ago
297e32126f
Merge pull request #2265 from RedSoxFan/implement-1962
...
Implement swaylock configuration file parsing
6 years ago
4657ea5a42
swayidle: cleanup
...
No idea why wlr_output_layout was involved here.
6 years ago
7b91712416
Switch to using getopt_long for config flag
6 years ago
14c949c1c7
Remove leftover parens
6 years ago
85584734ce
Remove int cast after changing to size_t
6 years ago
d375f6af18
Change to size_t in swaylock's get_config_path
6 years ago
296889f3d7
Implement swaylock configuration file parsing
6 years ago
6a9ca6efa0
Merge pull request #2283 from RyanDwyer/no-focus
...
Implement no_focus command
6 years ago
e2f28c023c
Focus view before running criteria when mapping
6 years ago
fc2484095a
Implement no_focus command
6 years ago
a588b326c2
Merge pull request #2282 from RyanDwyer/fix-tab-split-focus
...
Fix tab split focus bug
6 years ago
af5f736277
Render containers as urgent if they have an urgent child
6 years ago
9ca5cb7faf
Fix tab split focus bug
...
Fixes a bug where if you have a tab containing a split, then switch from
a non-split tab to the split tab, focus is not changed properly.
6 years ago
be28c18ad5
Mark containers as urgent in IPC if they have urgent views
6 years ago
5f0a4bb6a4
Update workspace urgent state when views close or move workspaces
6 years ago
560627437b
Make container_for_each_descendant_dfs descend into floating views
6 years ago
64e3bc3ab0
Fix crash in ipc_json_describe_view
...
I didn't expect a function called ipc_json_describe_view to be passed a
container which wasn't a view :\
6 years ago
Ryan Dwyer
emersion
Brian Ashworth
Drew DeVault
Ryan Dwyer
Peter Rice
frsfnrrg
Brian Ashworth