itycodes
/
convince
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implement resize grow|shrink <direction> <amount> or <amount>

Browse Source
master
Ryan Dwyer 6 years ago
parent 558ca9fc28
commit 5940682f40
1 changed files with 220 additions and 109 deletions
Show Stats Download Patch File Download Diff File

321
sway/commands/resize.c
Unescape View File

@ -29,6 +29,11 @@ enum resize_axis {
RESIZE_AXIS_INVALID, RESIZE_AXIS_INVALID,
}; };
struct resize_amount {
int amount;
enum resize_unit unit;
};
static enum resize_unit parse_resize_unit(const char *unit) { static enum resize_unit parse_resize_unit(const char *unit) {
if (strcasecmp(unit, "px") == 0) { if (strcasecmp(unit, "px") == 0) {
return RESIZE_UNIT_PX; return RESIZE_UNIT_PX;
@ -42,6 +47,30 @@ static enum resize_unit parse_resize_unit(const char *unit) {
return RESIZE_UNIT_INVALID; return RESIZE_UNIT_INVALID;
} }
// Parse arguments such as "10", "10px" or "10 px".
// Returns the number of arguments consumed.
static int parse_resize_amount(int argc, char **argv,
struct resize_amount *amount) {
char *err;
amount->amount = (int)strtol(argv[0], &err, 10);
if (*err) {
// e.g. 10px
amount->unit = parse_resize_unit(err);
return 1;
}
if (argc == 1) {
amount->unit = RESIZE_UNIT_DEFAULT;
return 1;
}
// Try the second argument
amount->unit = parse_resize_unit(argv[1]);
if (amount->unit == RESIZE_UNIT_INVALID) {
amount->unit = RESIZE_UNIT_DEFAULT;
return 1;
}
return 2;
}
static enum resize_axis parse_resize_axis(const char *axis) { static enum resize_axis parse_resize_axis(const char *axis) {
if (strcasecmp(axis, "width") == 0 || strcasecmp(axis, "horizontal") == 0) { if (strcasecmp(axis, "width") == 0 || strcasecmp(axis, "horizontal") == 0) {
return RESIZE_AXIS_HORIZONTAL; return RESIZE_AXIS_HORIZONTAL;
@ -202,36 +231,39 @@ static void resize_tiled(int amount, enum resize_axis axis) {
arrange_and_commit(parent->parent); arrange_and_commit(parent->parent);
} }
static void resize_floating(int amount, enum resize_axis axis) { /**
* Implement `resize <grow|shrink>` for a floating container.
*/
static struct cmd_results *resize_adjust_floating(enum resize_axis axis,
struct resize_amount *amount) {
struct sway_container *con = config->handler_context.current_container; struct sway_container *con = config->handler_context.current_container;
int grow_x = 0, grow_y = 0; int grow_x = 0, grow_y = 0;
int grow_width = 0, grow_height = 0; int grow_width = 0, grow_height = 0;
switch (axis) { switch (axis) {
case RESIZE_AXIS_HORIZONTAL: case RESIZE_AXIS_HORIZONTAL:
grow_x = -amount / 2; grow_x = -amount->amount / 2;
grow_width = amount; grow_width = amount->amount;
break; break;
case RESIZE_AXIS_VERTICAL: case RESIZE_AXIS_VERTICAL:
grow_y = -amount / 2; grow_y = -amount->amount / 2;
grow_height = amount; grow_height = amount->amount;
break; break;
case RESIZE_AXIS_UP: case RESIZE_AXIS_UP:
grow_y = -amount; grow_y = -amount->amount;
grow_height = amount; grow_height = amount->amount;
break; break;
case RESIZE_AXIS_LEFT: case RESIZE_AXIS_LEFT:
grow_x = -amount; grow_x = -amount->amount;
grow_width = amount; grow_width = amount->amount;
break; break;
case RESIZE_AXIS_DOWN: case RESIZE_AXIS_DOWN:
grow_height = amount; grow_height = amount->amount;
break; break;
case RESIZE_AXIS_RIGHT: case RESIZE_AXIS_RIGHT:
grow_width = amount; grow_width = amount->amount;
break; break;
case RESIZE_AXIS_INVALID: case RESIZE_AXIS_INVALID:
sway_assert(false, "Didn't expect RESIZE_AXIS_INVALID"); return cmd_results_new(CMD_INVALID, "resize", "Invalid axis/direction");
return;
} }
con->x += grow_x; con->x += grow_x;
con->y += grow_y; con->y += grow_y;
@ -247,80 +279,64 @@ static void resize_floating(int amount, enum resize_axis axis) {
} }
arrange_and_commit(con); arrange_and_commit(con);
return cmd_results_new(CMD_SUCCESS, NULL, NULL);
} }
static void resize(int amount, enum resize_axis axis, enum resize_unit unit) { /**
* Implement `resize <grow|shrink>` for a tiled container.
*/
static struct cmd_results *resize_adjust_tiled(enum resize_axis axis,
struct resize_amount *amount) {
struct sway_container *current = config->handler_context.current_container; struct sway_container *current = config->handler_context.current_container;
if (container_is_floating(current)) {
return resize_floating(amount, axis);
}
if (unit == RESIZE_UNIT_DEFAULT) { if (amount->unit == RESIZE_UNIT_DEFAULT) {
unit = RESIZE_UNIT_PPT; amount->unit = RESIZE_UNIT_PPT;
} }
if (unit == RESIZE_UNIT_PPT) { if (amount->unit == RESIZE_UNIT_PPT) {
float pct = amount / 100.0f; float pct = amount->amount / 100.0f;
// TODO: Make left/right/up/down resize in that direction?
switch (axis) { switch (axis) {
case RESIZE_AXIS_LEFT:
case RESIZE_AXIS_RIGHT:
case RESIZE_AXIS_HORIZONTAL: case RESIZE_AXIS_HORIZONTAL:
amount = (float)current->width * pct; amount->amount = (float)current->width * pct;
break; break;
case RESIZE_AXIS_UP:
case RESIZE_AXIS_DOWN:
case RESIZE_AXIS_VERTICAL: case RESIZE_AXIS_VERTICAL:
amount = (float)current->height * pct; amount->amount = (float)current->height * pct;
break; break;
default: case RESIZE_AXIS_INVALID:
sway_assert(0, "invalid resize axis"); return cmd_results_new(CMD_INVALID, "resize",
return; "Invalid resize axis/direction");
} }
} }
return resize_tiled(amount, axis); resize_tiled(amount->amount, axis);
return cmd_results_new(CMD_SUCCESS, NULL, NULL);
} }
// resize set <width> [px|ppt] <height> [px|ppt] /**
static struct cmd_results *cmd_resize_set(int argc, char **argv) { * Implement `resize set` for a tiled container.
struct cmd_results *error; */
if ((error = checkarg(argc, "resize", EXPECTED_AT_LEAST, 2))) { static struct cmd_results *resize_set_tiled(struct sway_container *con,
return error; struct resize_amount *width, struct resize_amount *height) {
}
struct sway_container *con = config->handler_context.current_container;
if (!container_is_floating(con)) {
return cmd_results_new(CMD_INVALID, "resize", return cmd_results_new(CMD_INVALID, "resize",
"resize set is not currently supported for tiled containers"); "'resize set' is not implemented for tiled views");
}
const char *usage = "Expected 'resize set <width> <height>'";
char *err;
size_t width = (int)strtol(*argv, &err, 10);
if (*err) {
// e.g. `resize set width 500px`
enum resize_unit unit = parse_resize_unit(err);
if (unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage);
}
}
--argc; ++argv;
if (parse_resize_unit(argv[0]) != RESIZE_UNIT_INVALID) {
--argc; ++argv;
}
if (!argc) {
return cmd_results_new(CMD_INVALID, "resize", usage);
}
size_t height = (int)strtol(*argv, &err, 10);
if (*err) {
// e.g. `resize set height 500px`
enum resize_unit unit = parse_resize_unit(err);
if (unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage);
}
} }
int grow_width = width - con->width; /**
int grow_height = height - con->height; * Implement `resize set` for a floating container.
*/
static struct cmd_results *resize_set_floating(struct sway_container *con,
struct resize_amount *width, struct resize_amount *height) {
int grow_width = width->amount - con->width;
int grow_height = height->amount - con->height;
con->x -= grow_width / 2; con->x -= grow_width / 2;
con->y -= grow_height / 2; con->y -= grow_height / 2;
con->width = width; con->width = width->amount;
con->height = height; con->height = height->amount;
if (con->type == C_VIEW) { if (con->type == C_VIEW) {
struct sway_view *view = con->sway_view; struct sway_view *view = con->sway_view;
@ -335,73 +351,168 @@ static struct cmd_results *cmd_resize_set(int argc, char **argv) {
return cmd_results_new(CMD_SUCCESS, NULL, NULL); return cmd_results_new(CMD_SUCCESS, NULL, NULL);
} }
struct cmd_results *cmd_resize(int argc, char **argv) { /**
struct sway_container *current = config->handler_context.current_container; * resize set <args>
if (!current) { *
return cmd_results_new(CMD_INVALID, "resize", "Cannot resize nothing"); * args: <width> [px|ppt] <height> [px|ppt]
} */
if (current->type != C_VIEW && current->type != C_CONTAINER) { static struct cmd_results *cmd_resize_set(int argc, char **argv) {
return cmd_results_new(CMD_INVALID, "resize",
"Can only resize views/containers");
}
struct cmd_results *error; struct cmd_results *error;
if ((error = checkarg(argc, "resize", EXPECTED_AT_LEAST, 2))) { if ((error = checkarg(argc, "resize", EXPECTED_AT_LEAST, 2))) {
return error; return error;
} }
const char *usage = "Expected 'resize set <width> <height>'";
if (strcasecmp(argv[0], "set") == 0) { // Width
return cmd_resize_set(argc - 1, &argv[1]); struct resize_amount width;
int num_consumed_args = parse_resize_amount(argc, argv, &width);
argc -= num_consumed_args;
argv += num_consumed_args;
if (width.unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage);
}
if (!argc) {
return cmd_results_new(CMD_INVALID, "resize", usage);
} }
const char *usage = "Expected 'resize <shrink|grow> " // Height
"<width|height|up|down|left|right> [<amount>] [px|ppt]'"; struct resize_amount height;
num_consumed_args = parse_resize_amount(argc, argv, &height);
int multiplier = 0; argc -= num_consumed_args;
if (strcasecmp(*argv, "grow") == 0) { argv += num_consumed_args;
multiplier = 1; if (height.unit == RESIZE_UNIT_INVALID) {
} else if (strcasecmp(*argv, "shrink") == 0) {
multiplier = -1;
} else {
return cmd_results_new(CMD_INVALID, "resize", usage); return cmd_results_new(CMD_INVALID, "resize", usage);
} }
--argc; ++argv;
// If 0, don't resize that dimension
struct sway_container *con = config->handler_context.current_container;
if (width.amount <= 0) {
width.amount = con->width;
}
if (height.amount <= 0) {
height.amount = con->height;
}
if (container_is_floating(con)) {
return resize_set_floating(con, &width, &height);
}
return resize_set_tiled(con, &width, &height);
}
/**
* resize <grow|shrink> <args>
*
* args: <direction>
* args: <direction> <amount> <unit>
* args: <direction> <amount> <unit> or <amount> <other_unit>
*/
static struct cmd_results *cmd_resize_adjust(int argc, char **argv,
int multiplier) {
const char *usage = "Expected 'resize grow|shrink <direction> "
"[<amount> px|ppt [or <amount> px|ppt]]'";
enum resize_axis axis = parse_resize_axis(*argv); enum resize_axis axis = parse_resize_axis(*argv);
if (axis == RESIZE_AXIS_INVALID) { if (axis == RESIZE_AXIS_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage); return cmd_results_new(CMD_INVALID, "resize", usage);
} }
--argc; ++argv; --argc; ++argv;
int amount = 10; // Default amount // First amount
enum resize_unit unit = RESIZE_UNIT_DEFAULT; struct resize_amount first_amount;
if (argc) { if (argc) {
char *err; int num_consumed_args = parse_resize_amount(argc, argv, &first_amount);
amount = (int)strtol(*argv, &err, 10); argc -= num_consumed_args;
if (*err) { argv += num_consumed_args;
// e.g. `resize grow width 10px` if (first_amount.unit == RESIZE_UNIT_INVALID) {
unit = parse_resize_unit(err);
if (unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage); return cmd_results_new(CMD_INVALID, "resize", usage);
} }
} } else {
--argc; ++argv; first_amount.amount = 10;
first_amount.unit = RESIZE_UNIT_DEFAULT;
} }
// "or"
if (argc) { if (argc) {
unit = parse_resize_unit(*argv); if (strcmp(*argv, "or") != 0) {
if (unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage); return cmd_results_new(CMD_INVALID, "resize", usage);
} }
--argc; ++argv; --argc; ++argv;
} }
// Second amount
struct resize_amount second_amount;
if (argc) { if (argc) {
// Provied too many args, the bastard int num_consumed_args = parse_resize_amount(argc, argv, &second_amount);
argc -= num_consumed_args;
argv += num_consumed_args;
if (second_amount.unit == RESIZE_UNIT_INVALID) {
return cmd_results_new(CMD_INVALID, "resize", usage); return cmd_results_new(CMD_INVALID, "resize", usage);
} }
} else {
second_amount.unit = RESIZE_UNIT_INVALID;
}
resize(amount * multiplier, axis, unit); first_amount.amount *= multiplier;
return cmd_results_new(CMD_SUCCESS, NULL, NULL); second_amount.amount *= multiplier;
struct sway_container *con = config->handler_context.current_container;
if (container_is_floating(con)) {
// Floating containers can only resize in px. Choose an amount which
// uses px, with fallback to an amount that specified no unit.
if (first_amount.unit == RESIZE_UNIT_PX) {
return resize_adjust_floating(axis, &first_amount);
} else if (second_amount.unit == RESIZE_UNIT_PX) {
return resize_adjust_floating(axis, &second_amount);
} else if (first_amount.unit == RESIZE_UNIT_DEFAULT) {
return resize_adjust_floating(axis, &first_amount);
} else if (second_amount.unit == RESIZE_UNIT_DEFAULT) {
return resize_adjust_floating(axis, &second_amount);
} else {
return cmd_results_new(CMD_INVALID, "resize",
"Floating containers cannot use ppt measurements");
}
}
// For tiling, prefer ppt -> default -> px
if (first_amount.unit == RESIZE_UNIT_PPT) {
return resize_adjust_tiled(axis, &first_amount);
} else if (second_amount.unit == RESIZE_UNIT_PPT) {
return resize_adjust_tiled(axis, &second_amount);
} else if (first_amount.unit == RESIZE_UNIT_DEFAULT) {
return resize_adjust_tiled(axis, &first_amount);
} else if (second_amount.unit == RESIZE_UNIT_DEFAULT) {
return resize_adjust_tiled(axis, &second_amount);
} else {
return resize_adjust_tiled(axis, &first_amount);
}
}
struct cmd_results *cmd_resize(int argc, char **argv) {
struct sway_container *current = config->handler_context.current_container;
if (!current) {
return cmd_results_new(CMD_INVALID, "resize", "Cannot resize nothing");
}
if (current->type != C_VIEW && current->type != C_CONTAINER) {
return cmd_results_new(CMD_INVALID, "resize",
"Can only resize views/containers");
}
struct cmd_results *error;
if ((error = checkarg(argc, "resize", EXPECTED_AT_LEAST, 2))) {
return error;
}
if (strcasecmp(argv[0], "set") == 0) {
return cmd_resize_set(argc - 1, &argv[1]);
}
if (strcasecmp(argv[0], "grow") == 0) {
return cmd_resize_adjust(argc - 1, &argv[1], 1);
}
if (strcasecmp(argv[0], "shrink") == 0) {
return cmd_resize_adjust(argc - 1, &argv[1], -1);
}
const char *usage = "Expected 'resize <shrink|grow> "
"<width|height|up|down|left|right> [<amount>] [px|ppt]'";
return cmd_results_new(CMD_INVALID, "resize", usage);
} }

Write Preview
Loading…
Cancel
Save