wlseeds

History

Simon Ser f5889319f7 backend/drm: fix queued cursor FB overwritten with NULL With the following sequence of events, the cursor FB fields could end up being all set to NULL while the cursor is enabled: 1. set_cursor is called, conn->cursor_pending_fb is set to a FB pointer. 2. The output is committed with a buffer. crtc->cursor->queued_fb is set to the FB pointer, conn->cursor_pending_fb is reset to NULL. A page-flip event is expected in the future. 3. The output is committed with a modeset before the page-flip event is triggered. crtc->cursor->queued_fb is reset to NULL. At this point all of crtc->cursor->current_fb, crtc->cursor->queued_fb and conn->cursor_pending_fb are NULL which is a bogus state when the cursor plane is enabled. To avoid this issue, avoid overwriting crtc->cursor->queued_fb with a NULL pointer on commit. The cursor logic still isn't great, but let's keep a rework of that for a separate patch. Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3734		9 months ago
..
atomic.c	backend/drm: don't destroy previous DRM master blobs	9 months ago
backend.c	backend/drm: move restore logic to drm.c	9 months ago
drm.c	backend/drm: fix queued cursor FB overwritten with NULL	9 months ago
fb.c	backend/drm: split wlr_drm_fb related functions into separate file	12 months ago
gen_pnpids.sh	backend/drm: use libdisplay-info to parse EDID	2 years ago
legacy.c	backend/drm: atomically reset state after VT switch	9 months ago
libliftoff.c	backend/drm: don't destroy previous DRM master blobs	9 months ago
meson.build	backend/drm: split wlr_drm_fb related functions into separate file	12 months ago
monitor.c	backend/drm: drop wl_display argument	10 months ago
properties.c	Define _POSIX_C_SOURCE globally	9 months ago
renderer.c	allocator: remove backend parameter in allocator_autocreate_with_drm_fd	10 months ago
util.c	Define _POSIX_C_SOURCE globally	9 months ago