You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Thomas Hebb 59b9518f07 render/gles2: don't constrain shm formats to ones that support reading ... commit 44e8451cd9 ("render/gles2: hide shm formats without GL support") added the is_gles2_pixel_format_supported() function to render/gles2/pixel_format.c, whose stated purpose is to "check whether the renderer has the needed GL extensions to read a given pixel format." It then used that function to filter the pixel formats returned by get_gles2_shm_formats(). The result of this change is that RGB formats are no longer reported for GL drivers that don't implement EXT_read_format_bgra, even when those formats are supported for rendering (which they have to be for wlr_gles2_renderer_create() to succeed). This is a pretty clear regression, since wlr_renderer_init_wl_shm() fails when either of WL_SHM_FORMAT_ARGB8888 or WL_SHM_FORMAT_XRGB8888 are missing. To fix the regression, change is_gles2_pixel_format_supported() to accept all pixel formats that support rendering, regardless of whether we can read them or not, and move the check for EXT_read_format_bgra back into gles2_read_pixels(). (There's already a check for this extension in gles2_preferred_read_format(), so we're not breaking any abstraction that wasn't already broken.) Tested on the NVIDIA 495.46 proprietary driver, which doesn't support EXT_read_format_bgra. Fixes: 44e8451cd9 ("render/gles2: hide shm formats without GL support")		3 years ago
..
allocator	Require INVALID for implicit format modifiers	3 years ago
gles2	render/gles2: don't constrain shm formats to ones that support reading	3 years ago
pixman	render/pixman: advertise MOD_INVALID instead of MOD_LINEAR	3 years ago
vulkan	vulkan: Fix imported image layout	3 years ago
dmabuf.c	render/dmabuf: make src arg const in wlr_dmabuf_attributes_copy	4 years ago
drm_format_set.c	render/drm-format-set: add wlr_drm_format_set_intersect	3 years ago
egl.c	render/egl: improve modifier support detection	3 years ago
meson.build	render: completely disable gles2 if requested but libEGL is found	3 years ago
pixel_format.c	render/pixel_format: add more formats for Pixman	3 years ago
swapchain.c	Move allocator stuff into new directory	3 years ago
wlr_renderer.c	render: add wlr_renderer_init_wl_shm	3 years ago
wlr_texture.c	render/wlr_texture: put wlr_texture_from_buffer into the public API	3 years ago