26b2012b5e
fix style issue
6 years ago
e6d613ca2e
fix: add stack update on focus change
...
Enable the stack update again for focus changes on non-focusable views.
6 years ago
f93234d6f5
fix: tabs instead of spaces
7 years ago
d0b3aed584
do not send focus request to a window that doesn't allow this
7 years ago
4a1c9a1925
xwm: fix use-after-free involving parents/children
...
Happens when e.g. closing gimp.
==24039==ERROR: AddressSanitizer: heap-use-after-free on address 0x6150001a7a78 at pc 0x7f09b09f1bb2 bp 0x7ffcf0237bf0 sp 0x7ffcf0237be0
WRITE of size 8 at 0x6150001a7a78 thread T0
#0 0x7f09b09f1bb1 in wl_list_remove ../util/signal.c:55
#1 0x7f09b094cf03 in xwayland_surface_destroy ../xwayland/xwm.c:295
#2 0x7f09b0950245 in xwm_handle_destroy_notify ../xwayland/xwm.c:717
#3 0x7f09b095304a in x11_event_handler ../xwayland/xwm.c:1149
#4 0x7f09b0c68f01 in wl_event_loop_dispatch src/event-loop.c:641
#5 0x7f09b0c67601 in wl_display_run src/wayland-server.c:1260
#6 0x40a2f4 in main ../sway/main.c:433
#7 0x7f09b011018a in __libc_start_main (/lib64/libc.so.6+0x2318a)
#8 0x40b749 in _start (/opt/wayland/bin/sway+0x40b749)
0x6150001a7a78 is located 120 bytes inside of 496-byte region [0x6150001a7a00,0x6150001a7bf0)
freed by thread T0 here:
#0 0x7f09b2b58880 in __interceptor_free (/lib64/libasan.so.5+0xee880)
#1 0x7f09b094d1a1 in xwayland_surface_destroy ../xwayland/xwm.c:315
#2 0x7f09b0950245 in xwm_handle_destroy_notify ../xwayland/xwm.c:717
#3 0x7f09b095304a in x11_event_handler ../xwayland/xwm.c:1149
#4 0x7f09b0c68f01 in wl_event_loop_dispatch src/event-loop.c:641
#5 0x7f09b0c67601 in wl_display_run src/wayland-server.c:1260
#6 0x40a2f4 in main ../sway/main.c:433
#7 0x7f09b011018a in __libc_start_main (/lib64/libc.so.6+0x2318a)
#8 0x40b749 in _start (/opt/wayland/bin/sway+0x40b749)
previously allocated by thread T0 here:
#0 0x7f09b2b58e50 in calloc (/lib64/libasan.so.5+0xeee50)
#1 0x7f09b094b585 in xwayland_surface_create ../xwayland/xwm.c:119
#2 0x7f09b0950151 in xwm_handle_create_notify ../xwayland/xwm.c:706
#3 0x7f09b0953032 in x11_event_handler ../xwayland/xwm.c:1146
#4 0x7f09b0c68f01 in wl_event_loop_dispatch src/event-loop.c:641
#5 0x7f09b0c67601 in wl_display_run src/wayland-server.c:1260
#6 0x40a2f4 in main ../sway/main.c:433
#7 0x7f09b011018a in __libc_start_main (/lib64/libc.so.6+0x2318a)
#8 0x40b749 in _start (/opt/wayland/bin/sway+0x40b749)
7 years ago
5dd1a838f3
xwm: set the proper event mask in client messages
...
Fixes #927
7 years ago
1a3921d4d4
Remove unused argument
7 years ago
72a75b3a72
Fix Xwayland cleanup
...
Fixes #964
7 years ago
8e831cd416
Merge pull request #959 from VincentVanlaer/xwayland-lazy
...
Add the option to start Xwayland only when a client connects
7 years ago
119a6cf35c
Make xwayland_finish* clean up wlr_xwayland
7 years ago
80586b8f6b
Clean up events
7 years ago
446ea3a340
Add beter handling for Xwayland failing at startup
7 years ago
c80bf1591e
Allow xwayland to start lazily
...
Makes the xwayland startup process two phased.
The first phase just initialises the X11 sockets.
The second phase starts the Xwayland server itself.
When starting xwayland lazily the second phase will be postponed until
a client has connected to the X11 socket.
Changes in behaviour:
The DISPLAY environment is now set immediately after the X11 sockets
are created.
When the Xwayland server is killed or crashes, the sockets will not be
recreated, but reused.
Fixes #849 : Start up Xwayland lazily
7 years ago
cf10cbc00c
Use UTF-8 xwayland window title if available
7 years ago
001045e47a
xwayland: make utility windows unmanaged again
...
7f70d244a9
7 years ago
04af09862a
Merge pull request #918 from emersion/xwayland-unmapped-request-configure
...
xwayland: forward configure events to compositor when unmapped
7 years ago
7f70d244a9
xwayland: fix some Chromium comboboxes
...
Some comboboxes (e.g. in chrome://flags) are advertized as…
Notifications of course! Yeah, notifications, the thing that
tells you you have mail, your battery is low, or the dog has
eaten your carpet. This isn't the first time we notice Chromium's
X11 backend is pretty shit.
Anyway, added notifications and splash screens to the list of
unmanaged windows. Also removed utility windows because those
should be managed, but maybe I'm wrong and I'll revert this.
7 years ago
af668ceb7c
xwayland: forward configure events to compositor when unmapped
7 years ago
c119c43b48
xwayland/selection: fix little memory leak on error
7 years ago
fac2c3e25f
Merge pull request #882 from emersion/unprefix-local-symbols
...
Remove wlr_ prefix from local symbols
7 years ago
085452f9d9
Use correct printf format specifiers for ssize_t
...
This unbreaks the build on armhf that otherwise fails like
../xwayland/selection/incoming.c: In function 'xwm_data_source_write':
../include/wlr/util/log.h:34:17: error: format '%ld' expects argument of type 'long int', but argument 6 has type 'ssize_t {aka int}' [-Werror=format=]
_wlr_log(verb, "[%s:%d] " fmt, wlr_strip_path(__FILE__), __LINE__, ##__VA_ARGS__)
^
../xwayland/selection/incoming.c:34:2: note: in expansion of macro 'wlr_log'
wlr_log(L_DEBUG, "wrote %zd (chunk size %ld) of %d bytes",
^~~~~~~
../xwayland/selection/incoming.c:34:44: note: format string is defined here
wlr_log(L_DEBUG, "wrote %zd (chunk size %ld) of %d bytes",
~~^
%d
7 years ago
625a7a48dc
Don't use the wlr_ prefix for static functions
7 years ago
71ca45e2c0
Make sure we don't use others' prefixes
7 years ago
12bf39a715
Merge pull request #885 from emersion/remove-surface-subsurface
...
Remove wlr_surface::subsurface, add wlr_subcompositor
7 years ago
a470f101c1
xwayland: preserve the PATH variable
...
Some systems don't have xwayland in /usr/bin, but in other paths.
wlroots was unable to find Xwayland binaries outside of standard locations
7 years ago
3bce5dfc9f
Fix segfaults in wlr_surface_is_*
7 years ago
fa02e30adf
xwayland: emit new_surface when unmapped
7 years ago
8dec7036d0
Always unmap before destroying surface
7 years ago
17d0440b75
Add wlr_xwayland_surface_ping
7 years ago
c55ad11d96
xwayland: add _NET_WM_WINDOW_TYPE_MENU support
7 years ago
8b07a4d055
Emit xwayland unmap signal before unmapping
...
This allows compositors to access the surface being unmapped. This
is also more consistent with the destroy signal.
7 years ago
591ea27cf9
xwayland: refactor selection code
7 years ago
67dec2da2b
xwayland: fix incoming incr transfers
7 years ago
58ac05c276
Merge branch 'master' into xwayland-dnd
7 years ago
1cd7ff7d3a
xwayland: use strndup in xwm_get_atom_name
7 years ago
d7e03c7adc
xwayland: fix outgoing incr transfers
7 years ago
8f84c5b05f
xwayland: only send one target at a time
7 years ago
103e59703f
xwayland: improve xwm_selection_send_notify
7 years ago
506acbdecd
Missed a spot
7 years ago
92b74071d0
xwayland: support multiple wayland → xwayland selection transfers
...
This fixes drag'n'drop support for Chromium.
7 years ago
8836b4f024
Merge branch 'master' into xwayland-dnd
7 years ago
692f1746cf
xwayland: specify xwm cursor stride in bytes
7 years ago
865b0aa123
xwayland: rename map_notify to map for consistency
7 years ago
cadfccf1fd
xwayland: use a separate window for drag'n'drop
7 years ago
79dd4a0ff9
xwayland: receive DND_FINISHED
7 years ago
ca2a73b90d
xwayland: allow drag data source transfer after drag ends
7 years ago
5dc5f446a8
xwayland: send drag'n'drop action to data source
7 years ago
6fd50947bd
xwayland: improve error handling
7 years ago
3effe153bc
xwayland: make wayland → xwayland work
7 years ago
30babb3865
xwayland: send DND_LEAVE
7 years ago
e208f8dd8c
xwayland: fixes events not flushed causing issues with GTK apps
7 years ago
bde859452d
xwayland: print names of unsupported properties and client messages
7 years ago
2a34b154e6
xwayland: send DND_DROP
7 years ago
73394deb76
xwayland: send DND_POSITION
7 years ago
0d7a81ccdf
xwayland: send DND_ENTER
7 years ago
b6c1760de5
xwayland: create DND window, add DND atom helpers
7 years ago
e78252adab
Fix segfault in xwm_read_data_source
7 years ago
2910972b25
xwm.h: fix guard ifdef and remove wlr_ prefix from xwm_atoms_contains
7 years ago
d9a724c4a2
xcb errors: init errors context at start
...
`xcb_errors_context_new` is more than just a malloc, it does a few
xcb requests so we benefit from not generating a new context everytime
7 years ago
7d1870c6f1
move xwm.h out of include/wlr
...
xwm.h was meant to be private, so move it to include/xwayland/xwm.h
We had an ifdef WLR_HAS_XCB_ICCCM in xwayland.h which was easy to move
to xwm, it is not safe to use the WLR_HAS_* in the public headers.
I checked a few of our current users and none rely on xwm.h being
public as expected (rootston, sway, hsroots)
7 years ago
f481791669
xcb error: get unhandled events names
...
This provides more friendly debug messages for unhandled events,
for example:
[xwayland/xwm.c:1033] unhandled X11 event: FocusOut (10)
[xwayland/xwm.c:1033] unhandled X11 event: MappingNotify (34)
7 years ago
8026cd2a06
xcb error: always log sequence
7 years ago
6f9da97565
xcb errors: address declare-assign style
7 years ago
f8428d1063
xcb errors: optional dependency with improved messages
...
Now message can look like:
[xwayland/xwm.c:991] xcb error: op ChangeProperty (no minor), code Window (no extension), value 6291465
instead of this one when the lib is not available:
[xwayland/xwm.c:999] xcb error: op 18:0, code 3, sequence 103, value 6291465
The value in case of Window is the window id, so we can tell what
function applied on which window which is a good start.
The sequence ought to be able to tell us more precisely which
invocation it was, but we never log it when calling functions
so is useless in practice and no longer logged.
7 years ago
2a9ba5c8dc
xcb errors: log raw values
7 years ago
5ec06dcecd
xwm: fix call of xcb_change_window_attributes for old gcc versions
...
gcc 6.3.0 (at least) complains about &values:
expected ‘const uint32_t * {aka const unsigned int *}’ but argument
is of type ‘uint32_t (*)[1] {aka unsigned int (*)[1]}’
Reported by thorwil on irc
7 years ago
bb676013ed
add xwayland unmanaged tests to support dmenu
...
This adds `wlr_xwayland_surface_is_unamanged`, to allow compositors more
fine grained control over XWayland focus.
A surface that is unmanaged should not receive focus, while other
windows that are just override redirect may want it (dmenu).
The way unamanged is determined is taken from wlc.
7 years ago
b1e2718dd7
xwayland: fix some use-after-free in xwm
7 years ago
1d9be89e2d
Revert "ELF Visibility"
7 years ago
86269052eb
Explicitly export EFL symbols
7 years ago
8c1cc45c7d
Merge pull request #629 from emersion/safe-wl-resource-get-user-data
...
Wrap wl_resource_get_user_data into safer helper functions
7 years ago
168e26489a
Add missing dependencies
7 years ago
392d54a35d
Wrap wl_resource_get_user_data into safer helper functions
...
This ensures we're not incorrectly casting a resource.
Fixes #628
7 years ago
c2e1474010
Reformat all #include directives
7 years ago
36ead80cd1
Make wlr_signal_emit_safe private
7 years ago
5e58d46cc1
Add wlr_signal_emit_safe
7 years ago
59c53e8333
Merge remote-tracking branch 'upstream/master' into output-damage
7 years ago
f704c3d42b
rootston: fix damage tracking for fullscreen xwayland views
7 years ago
47eb478c35
style: add else keywords in xwm.c
7 years ago
dcc743047b
style: include brackets for if/while/for, even if it's a single statement
7 years ago
eeffe11337
surface: add wlr_surface new_subsurface and wlr_subsurface destroy events
7 years ago
65b28b3823
xwayland: render children window in fullscreen
7 years ago
38ed3b4245
seat: rename selection_source to selection_data_source, remove unused data_device
7 years ago
6ed1884c84
xwm_get_render_format: fix typo in error message
7 years ago
ec952931a1
wlr_xwayland: preserve end of struct on restart
...
This is more robust than trying to recopy a few fields.
Note: wlr_xwayland->events.ready now resets after each trigger, so one can
hook on it again and be called when restart is ready
7 years ago
a6fb4b007b
xwm_get_render_format: check NULL return value
7 years ago
41649a1f9a
xwm_selection_finish: set NULL seat for xwayland
...
While they could eventually be split appart, the current approach could lead to
double wl_list_remove() calls on selections which is incorrect
7 years ago
e0eafa0429
xwayland: listen to wlr_seat destroy signal
7 years ago
61b91a5721
xwayland restart: copy seat and events over
...
This is very ugly, there must be a better way to do that (not memset it?)
Meanwhile, this fixes rootston xwayland on restart
7 years ago
bb0d888f25
xwayland selection: further cleanup on Xwayland exit
...
This is necessary if our last primary/clipboard selection was on Xwayland,
and we try to paste to native wayland after Xwayland died
7 years ago
f8a346380c
xwayland xwm_get_render_format: free reply
7 years ago
dad9543c51
Xwayland: remove xwm from selection seat listeners on destroy
7 years ago
e5dd98c7f5
xwayland/selection: handle wl_array_add failure better
...
Just abort and deregister instead of trying to throw some input out,
which would have lead to inconsistent paste
7 years ago
3eb4fa15ee
ENOMEM checks: consistently check wl_array_add return
7 years ago
ff13849624
config: Avoid clash with other config-headers
7 years ago
a79dc7df51
Merge pull request #524 from acrisci/role-committed
...
[wip] Role committed
7 years ago
5c5f0611c4
xwayland: role committed
7 years ago
e809250171
Merge pull request #519 from emersion/xwayland-primary-selection
...
Implement xwayland primary selection sync
7 years ago
1c9b09ca92
Add logging to selection message handlers
7 years ago
b3072f81fe
Allow calling xwm_set_seat with a NULL seat
7 years ago
57a09c8ca4
config: Put all defines into config.h
7 years ago
998267e291
Fix primary selection not sent to xwayland when clipboard is empty
7 years ago
4a11609b76
Fix use-after-free when destroying selection sources
7 years ago
cdc21cdcff
Properly free selection sources
7 years ago
6dffaa7bb7
Implement xwayland primary selection sync
7 years ago
810c4b119b
Fix clipboard from xwayland to wayland
7 years ago
76dcb694c1
Send empty selection when clipboard is empty
7 years ago
5584f42c1e
Destroy xwm selection window on destroy
7 years ago
6b42bfad18
Merge branch 'master' into xwm-selection
7 years ago
b884025558
Deny access to clipboard if no xwayland window is focused
7 years ago
75ef7860bb
Merge branch 'master' into display-destroy
7 years ago
343efd0c20
Only reply to clipboard selection events
7 years ago
a4094c82c7
Support selection MIME types from wayland to xwayland
7 years ago
62a16a356d
Support selection MIME types from xwayland to wayland
7 years ago
6ef0219763
Merge branch 'master' into xwm-selection
7 years ago
ea4b871e16
xwm: user custom event handler
7 years ago
c67a5824b8
Merge branch 'master' into display-destroy
7 years ago
4da4048189
remove todo
7 years ago
a4bb0574c4
selection fixes
7 years ago
52cda5653b
Revert "xwm: only take clipboard if window is focused"
...
This reverts commit e3542d879d
7 years ago
35188834db
Merge branch 'master' into feature/xwm-selection
7 years ago
31bafc2461
xwm: use edges enum
7 years ago
e30b943fbd
Destroy xwayland client when possible
7 years ago
b06535718d
Do not destroy wl_client in wlr_xwayland_finish
7 years ago
18eb1eee3f
Listen to display destroy in xwayland, rename wlr_egl_free
7 years ago
86df909256
xwayland: remove xwayland param from xsurface methods
7 years ago
5d7eb438d9
Merge pull request #437 from emersion/fullscreen
...
Fullscreen support
7 years ago
e3542d879d
xwm: only take clipboard if window is focused
7 years ago
1ae944c071
Use SIGUSR2 for vt switching instead of SIGUSR1
...
Xwayland uses SIGUSR1 to signal readiness.
With direct(-freebsd) session and Xwayland, wlroots was confusing the
Xwayland readiness signal with a vt switch signal, freezing the desktop.
Same problem was found in Weston in 2014:
https://phabricator.freedesktop.org/T7080
7 years ago
fc17c74516
xwayland: clean up seat setting
7 years ago
b0683874e9
xwm: send selection data
7 years ago
71aa634ac5
Fix Xwayland second socket path on non-Linux systems
...
It was creating two sockets with the same path
7 years ago
ea6f77b484
xwm: get selection data
7 years ago
39e2ea8420
xwm: get selection targets
7 years ago
dcb168914e
Merge branch 'master' into fullscreen
7 years ago
1ada1b7f0b
xwm: x11 data source
7 years ago
c67cf2e9e4
xwm: handle selection stubs
7 years ago
1f976a0f25
xwm: xfixes selection notify
7 years ago
e786d17f63
Merge branch 'master' into feature/xwm-selection
7 years ago
151901123f
Merge branch 'master' into refactor-wlr-list
7 years ago
bc68f26960
Fix evince fullscreen under xwayland
7 years ago
444257b6b1
xwm: selection init
7 years ago
3880fb0a53
xwm: selection stubs
7 years ago
0672d9cb52
bug: properly send WM_STATE
7 years ago
016744ef4d
Refactor wlr_list inside wlroots
7 years ago
a317ecdab8
Run startup command after xwayland is ready
7 years ago
26dadacb71
Add wl_shell support for maximized views
7 years ago
758514fe5d
Fix xwayland _NET_WM_STATE handling
7 years ago
900fb326f7
Fixes segfault when no xcb_render_pictforminfo_t is available
7 years ago
bb76f52640
Fetch xcb_render_pictformat_t at startup
7 years ago
3f4ad47421
Use compositor theme for xwm cursor
7 years ago
ddd7b7711c
Load xwm cursor from theme
7 years ago
4254c28138
Free xwm cursor in xwm_destroy
7 years ago
bdaf66a292
Set xwayland root cursor
7 years ago
bf225a60d8
rootston: flush 'close' command on Xwayland
...
The close would otherwise wait for another xcb event to happen.
Flushing helps 'close' feel reactive.
7 years ago
ce72a687ce
xwm: cleanup send focus window logic
7 years ago
88316e7921
xwm: get rid of xcb call macro
7 years ago
942a19a069
xwm: cleanup and consistent naming
7 years ago
680f8a169d
xwm: remove duplicate calls in net wm state read
7 years ago
325def3841
xwm: create colormap and visual depth detection
7 years ago
be297d9d14
xwm: net wm state
7 years ago
6a4290b86a
xwm: moveresize events
7 years ago
4a106648c4
xwm: remove incorrect implementation of net wm state
7 years ago
32b848bd46
xwm: handle focus in
7 years ago
930ab06857
xwm: send net_wm_state
7 years ago
263279b7e0
xwm: rewrite xwm initialization
7 years ago
ff0006d0f0
xwm: refactor client message handler
7 years ago
a861b380ef
xwm: add net active window to supported
7 years ago
7914f4bda9
xwm: dont focus override redirect windows
7 years ago
d6a1e6fd79
xwm: dont flush if no events
7 years ago
b443b9a998
xwm: set net active window on xwm create
7 years ago
0d1dd84a48
xwm: improve activation and dont send focus twice
7 years ago
1be650d78a
xwm: only emit unmap notify once
7 years ago
e5ee01254b
xwm: map and unmap notify
7 years ago
22435e00c5
xwm: 80col cleanup
7 years ago
7643765e7b
xwm: unpaired surface list cleanup
7 years ago
3277c6d994
Fix order of WM_HINTS and WM_PROTOCOLS in xwm atom_map
7 years ago
2ff94d0036
xwm: get rid of displayable surfaces list
7 years ago
79e14f65e0
xwm: fix lists
7 years ago
fa94a06fd6
xwm: handle configure notify
7 years ago
a9d70a6256
xwm: set window attributes on create
7 years ago
a3f2754668
xwm: add surface to rootston on surface commit
7 years ago
c666d34d2d
xwm: add missing atoms to list
7 years ago
79978383ba
xwm: net active window
7 years ago
03bd34e826
xwm: atom cleanup
7 years ago
2ca502b546
Merge branch 'master' into feature/xwm-rewrite
7 years ago
0f7f6b1373
xwm: refactor xwm init
7 years ago
1dbe314937
Merge branch 'master' into feature/data-device-selection
7 years ago
c5fff08f8a
Forgot to rename these
7 years ago
fb25adae36
xwayland: use xfixes extension
7 years ago
a5fe9aa736
Add FreeBSD compatibility
7 years ago
6aafc2f61a
Merge pull request #223 from versusvoid/xwayland-activate
...
Activate only active xwayland views
7 years ago
528f000a7a
Deactivate xwayland when focus leaves there
7 years ago
c22b02618c
Flush xwayland surface configuration
...
Fix #215
7 years ago
12b9b1a4bd
Copy xcb_icccm structs into wlroots
7 years ago
454a6a902b
Parse _MOTIF_HINTS
7 years ago
fc61e82795
Use pointers for xwayland hints and size_hints
7 years ago
267f24753f
Add support for WM_HINTS
7 years ago
ed9796ec68
xwayland: parse normal hints
7 years ago
ef5914bdb6
xwayland: add wlr_xwayland_surface->motif_hints
7 years ago
Armin Preiml
Dominique Martinet
Ilia Bozhinov
Scott Anderson
Vincent Vanlaer
emersion
Drew DeVault
Guido Guenther
n3rdopolis
Markus Ongyerth
Scott Anderson
Rodrigo Lourenço
Johannes Schramm
Björn Esser
Tony Crisci
Greg V
Alexander Taylor
Versus Void