c119c43b48
xwayland/selection: fix little memory leak on error
8 years ago
fac2c3e25f
Merge pull request #882 from emersion/unprefix-local-symbols
...
Remove wlr_ prefix from local symbols
8 years ago
085452f9d9
Use correct printf format specifiers for ssize_t
...
This unbreaks the build on armhf that otherwise fails like
../xwayland/selection/incoming.c: In function 'xwm_data_source_write':
../include/wlr/util/log.h:34:17: error: format '%ld' expects argument of type 'long int', but argument 6 has type 'ssize_t {aka int}' [-Werror=format=]
_wlr_log(verb, "[%s:%d] " fmt, wlr_strip_path(__FILE__), __LINE__, ##__VA_ARGS__)
^
../xwayland/selection/incoming.c:34:2: note: in expansion of macro 'wlr_log'
wlr_log(L_DEBUG, "wrote %zd (chunk size %ld) of %d bytes",
^~~~~~~
../xwayland/selection/incoming.c:34:44: note: format string is defined here
wlr_log(L_DEBUG, "wrote %zd (chunk size %ld) of %d bytes",
~~^
%d
8 years ago
625a7a48dc
Don't use the wlr_ prefix for static functions
8 years ago
71ca45e2c0
Make sure we don't use others' prefixes
8 years ago
12bf39a715
Merge pull request #885 from emersion/remove-surface-subsurface
...
Remove wlr_surface::subsurface, add wlr_subcompositor
8 years ago
a470f101c1
xwayland: preserve the PATH variable
...
Some systems don't have xwayland in /usr/bin, but in other paths.
wlroots was unable to find Xwayland binaries outside of standard locations
8 years ago
3bce5dfc9f
Fix segfaults in wlr_surface_is_*
8 years ago
fa02e30adf
xwayland: emit new_surface when unmapped
8 years ago
8dec7036d0
Always unmap before destroying surface
8 years ago
17d0440b75
Add wlr_xwayland_surface_ping
8 years ago
c55ad11d96
xwayland: add _NET_WM_WINDOW_TYPE_MENU support
8 years ago
8b07a4d055
Emit xwayland unmap signal before unmapping
...
This allows compositors to access the surface being unmapped. This
is also more consistent with the destroy signal.
8 years ago
591ea27cf9
xwayland: refactor selection code
8 years ago
67dec2da2b
xwayland: fix incoming incr transfers
8 years ago
58ac05c276
Merge branch 'master' into xwayland-dnd
8 years ago
1cd7ff7d3a
xwayland: use strndup in xwm_get_atom_name
8 years ago
d7e03c7adc
xwayland: fix outgoing incr transfers
8 years ago
8f84c5b05f
xwayland: only send one target at a time
8 years ago
103e59703f
xwayland: improve xwm_selection_send_notify
8 years ago
506acbdecd
Missed a spot
8 years ago
92b74071d0
xwayland: support multiple wayland → xwayland selection transfers
...
This fixes drag'n'drop support for Chromium.
8 years ago
8836b4f024
Merge branch 'master' into xwayland-dnd
8 years ago
692f1746cf
xwayland: specify xwm cursor stride in bytes
8 years ago
865b0aa123
xwayland: rename map_notify to map for consistency
8 years ago
cadfccf1fd
xwayland: use a separate window for drag'n'drop
8 years ago
79dd4a0ff9
xwayland: receive DND_FINISHED
8 years ago
ca2a73b90d
xwayland: allow drag data source transfer after drag ends
8 years ago
5dc5f446a8
xwayland: send drag'n'drop action to data source
8 years ago
6fd50947bd
xwayland: improve error handling
8 years ago
3effe153bc
xwayland: make wayland → xwayland work
8 years ago
30babb3865
xwayland: send DND_LEAVE
8 years ago
e208f8dd8c
xwayland: fixes events not flushed causing issues with GTK apps
8 years ago
bde859452d
xwayland: print names of unsupported properties and client messages
8 years ago
2a34b154e6
xwayland: send DND_DROP
8 years ago
73394deb76
xwayland: send DND_POSITION
8 years ago
0d7a81ccdf
xwayland: send DND_ENTER
8 years ago
b6c1760de5
xwayland: create DND window, add DND atom helpers
8 years ago
e78252adab
Fix segfault in xwm_read_data_source
8 years ago
2910972b25
xwm.h: fix guard ifdef and remove wlr_ prefix from xwm_atoms_contains
8 years ago
d9a724c4a2
xcb errors: init errors context at start
...
`xcb_errors_context_new` is more than just a malloc, it does a few
xcb requests so we benefit from not generating a new context everytime
8 years ago
7d1870c6f1
move xwm.h out of include/wlr
...
xwm.h was meant to be private, so move it to include/xwayland/xwm.h
We had an ifdef WLR_HAS_XCB_ICCCM in xwayland.h which was easy to move
to xwm, it is not safe to use the WLR_HAS_* in the public headers.
I checked a few of our current users and none rely on xwm.h being
public as expected (rootston, sway, hsroots)
8 years ago
f481791669
xcb error: get unhandled events names
...
This provides more friendly debug messages for unhandled events,
for example:
[xwayland/xwm.c:1033] unhandled X11 event: FocusOut (10)
[xwayland/xwm.c:1033] unhandled X11 event: MappingNotify (34)
8 years ago
8026cd2a06
xcb error: always log sequence
8 years ago
6f9da97565
xcb errors: address declare-assign style
8 years ago
f8428d1063
xcb errors: optional dependency with improved messages
...
Now message can look like:
[xwayland/xwm.c:991] xcb error: op ChangeProperty (no minor), code Window (no extension), value 6291465
instead of this one when the lib is not available:
[xwayland/xwm.c:999] xcb error: op 18:0, code 3, sequence 103, value 6291465
The value in case of Window is the window id, so we can tell what
function applied on which window which is a good start.
The sequence ought to be able to tell us more precisely which
invocation it was, but we never log it when calling functions
so is useless in practice and no longer logged.
8 years ago
2a9ba5c8dc
xcb errors: log raw values
8 years ago
5ec06dcecd
xwm: fix call of xcb_change_window_attributes for old gcc versions
...
gcc 6.3.0 (at least) complains about &values:
expected ‘const uint32_t * {aka const unsigned int *}’ but argument
is of type ‘uint32_t (*)[1] {aka unsigned int (*)[1]}’
Reported by thorwil on irc
8 years ago
bb676013ed
add xwayland unmanaged tests to support dmenu
...
This adds `wlr_xwayland_surface_is_unamanged`, to allow compositors more
fine grained control over XWayland focus.
A surface that is unmanaged should not receive focus, while other
windows that are just override redirect may want it (dmenu).
The way unamanged is determined is taken from wlc.
8 years ago
b1e2718dd7
xwayland: fix some use-after-free in xwm
8 years ago
1d9be89e2d
Revert "ELF Visibility"
8 years ago
86269052eb
Explicitly export EFL symbols
8 years ago
8c1cc45c7d
Merge pull request #629 from emersion/safe-wl-resource-get-user-data
...
Wrap wl_resource_get_user_data into safer helper functions
8 years ago
168e26489a
Add missing dependencies
8 years ago
392d54a35d
Wrap wl_resource_get_user_data into safer helper functions
...
This ensures we're not incorrectly casting a resource.
Fixes #628
8 years ago
c2e1474010
Reformat all #include directives
8 years ago
36ead80cd1
Make wlr_signal_emit_safe private
8 years ago
5e58d46cc1
Add wlr_signal_emit_safe
8 years ago
59c53e8333
Merge remote-tracking branch 'upstream/master' into output-damage
8 years ago
f704c3d42b
rootston: fix damage tracking for fullscreen xwayland views
8 years ago
47eb478c35
style: add else keywords in xwm.c
8 years ago
dcc743047b
style: include brackets for if/while/for, even if it's a single statement
8 years ago
eeffe11337
surface: add wlr_surface new_subsurface and wlr_subsurface destroy events
8 years ago
65b28b3823
xwayland: render children window in fullscreen
8 years ago
38ed3b4245
seat: rename selection_source to selection_data_source, remove unused data_device
8 years ago
6ed1884c84
xwm_get_render_format: fix typo in error message
8 years ago
ec952931a1
wlr_xwayland: preserve end of struct on restart
...
This is more robust than trying to recopy a few fields.
Note: wlr_xwayland->events.ready now resets after each trigger, so one can
hook on it again and be called when restart is ready
8 years ago
a6fb4b007b
xwm_get_render_format: check NULL return value
8 years ago
41649a1f9a
xwm_selection_finish: set NULL seat for xwayland
...
While they could eventually be split appart, the current approach could lead to
double wl_list_remove() calls on selections which is incorrect
8 years ago
e0eafa0429
xwayland: listen to wlr_seat destroy signal
8 years ago
61b91a5721
xwayland restart: copy seat and events over
...
This is very ugly, there must be a better way to do that (not memset it?)
Meanwhile, this fixes rootston xwayland on restart
8 years ago
bb0d888f25
xwayland selection: further cleanup on Xwayland exit
...
This is necessary if our last primary/clipboard selection was on Xwayland,
and we try to paste to native wayland after Xwayland died
8 years ago
f8a346380c
xwayland xwm_get_render_format: free reply
8 years ago
dad9543c51
Xwayland: remove xwm from selection seat listeners on destroy
8 years ago
e5dd98c7f5
xwayland/selection: handle wl_array_add failure better
...
Just abort and deregister instead of trying to throw some input out,
which would have lead to inconsistent paste
8 years ago
3eb4fa15ee
ENOMEM checks: consistently check wl_array_add return
8 years ago
ff13849624
config: Avoid clash with other config-headers
8 years ago
a79dc7df51
Merge pull request #524 from acrisci/role-committed
...
[wip] Role committed
8 years ago
5c5f0611c4
xwayland: role committed
8 years ago
e809250171
Merge pull request #519 from emersion/xwayland-primary-selection
...
Implement xwayland primary selection sync
8 years ago
1c9b09ca92
Add logging to selection message handlers
8 years ago
b3072f81fe
Allow calling xwm_set_seat with a NULL seat
8 years ago
57a09c8ca4
config: Put all defines into config.h
8 years ago
998267e291
Fix primary selection not sent to xwayland when clipboard is empty
8 years ago
4a11609b76
Fix use-after-free when destroying selection sources
8 years ago
cdc21cdcff
Properly free selection sources
8 years ago
6dffaa7bb7
Implement xwayland primary selection sync
8 years ago
810c4b119b
Fix clipboard from xwayland to wayland
8 years ago
76dcb694c1
Send empty selection when clipboard is empty
8 years ago
5584f42c1e
Destroy xwm selection window on destroy
8 years ago
6b42bfad18
Merge branch 'master' into xwm-selection
8 years ago
b884025558
Deny access to clipboard if no xwayland window is focused
8 years ago
75ef7860bb
Merge branch 'master' into display-destroy
8 years ago
343efd0c20
Only reply to clipboard selection events
8 years ago
a4094c82c7
Support selection MIME types from wayland to xwayland
8 years ago
62a16a356d
Support selection MIME types from xwayland to wayland
8 years ago
6ef0219763
Merge branch 'master' into xwm-selection
8 years ago
ea4b871e16
xwm: user custom event handler
8 years ago
c67a5824b8
Merge branch 'master' into display-destroy
8 years ago
4da4048189
remove todo
8 years ago
emersion
Drew DeVault
Guido Guenther
n3rdopolis
Dominique Martinet
Markus Ongyerth
Scott Anderson
Rodrigo Lourenço
Johannes Schramm
Björn Esser
Tony Crisci