Fix option parsing

Using 'flag' results in duplicate code paths for short and long options.

This broke the -q short option in swaymsg, because there was:

 {"quiet", no_argument, &quiet, 'q'}

Which will set quiet to 'q' and return 0, not 'q'.
master
Christoph Gysin 9 years ago
parent bf97a5ada5
commit 923c3245ac

@ -57,10 +57,10 @@ int main(int argc, char **argv) {
static struct option long_options[] = {
{"help", no_argument, NULL, 'h'},
{"config", required_argument, NULL, 'c'},
{"validate", no_argument, &validate, 1},
{"debug", no_argument, &debug, 1},
{"validate", no_argument, NULL, 'C'},
{"debug", no_argument, NULL, 'd'},
{"version", no_argument, NULL, 'v'},
{"verbose", no_argument, &verbose, 1},
{"verbose", no_argument, NULL, 'V'},
{"get-socketpath", no_argument, NULL, 'p'},
{0, 0, 0, 0}
};
@ -87,8 +87,6 @@ int main(int argc, char **argv) {
break;
}
switch (c) {
case 0: // Flag
break;
case 'h': // help
fprintf(stdout, "%s", usage);
exit(EXIT_SUCCESS);

@ -128,10 +128,10 @@ int main(int argc, char **argv) {
static struct option long_options[] = {
{"help", no_argument, NULL, 'h'},
{"capture", no_argument, &capture, 'c'},
{"capture", no_argument, NULL, 'c'},
{"version", no_argument, NULL, 'v'},
{"socket", required_argument, NULL, 's'},
{"raw", no_argument, &raw, 'r'},
{"raw", no_argument, NULL, 'r'},
{"rate", required_argument, NULL, 'R'},
{0, 0, 0, 0}
};
@ -154,8 +154,6 @@ int main(int argc, char **argv) {
break;
}
switch (c) {
case 0: // Flag
break;
case 's': // Socket
socket_path = strdup(optarg);
break;

@ -24,7 +24,7 @@ int main(int argc, char **argv) {
static struct option long_options[] = {
{"help", no_argument, NULL, 'h'},
{"quiet", no_argument, &quiet, 'q'},
{"quiet", no_argument, NULL, 'q'},
{"version", no_argument, NULL, 'v'},
{"socket", required_argument, NULL, 's'},
{"type", required_argument, NULL, 't'},
@ -48,7 +48,8 @@ int main(int argc, char **argv) {
break;
}
switch (c) {
case 0: // Flag
case 'q': // Quiet
quiet = 1;
break;
case 's': // Socket
socket_path = strdup(optarg);

Loading…
Cancel
Save