Fix segfault in set_mode

best is NULL prior to being assigned to a mode. Closes: https://github.com/swaywm/sway/issues/4705 Fixes: f33dcd4c60 ("Prefer higher refresh rate default modes")
5 years ago · 01b5350bdc
parent f33dcd4c60
commit 01b5350bdc
1 changed files with 3 additions and 1 deletions
--- a/sway/config/output.c
+++ b/sway/config/output.c
@ -222,7 +222,9 @@ static bool set_mode(struct wlr_output *output, int width, int height,
 				best = mode;
 				break;
 			}
-			best = mode->refresh > best->refresh ? mode : best;
+			if (best == NULL || mode->refresh > best->refresh) {
+				best = mode;
+			}
 		}
 	}
 	if (!best) {