From d80c46250dad4b35d17b96427111c5073162da9d Mon Sep 17 00:00:00 2001
From: Kirill Primak <vyivel@eclair.cafe>
Date: Sun, 11 Feb 2024 10:47:35 +0300
Subject: [PATCH] backend/wayland: improve/fix xdg_toplevel (re-)initialization

- Reset all variables representing an initialized xdg_toplevel's state
on unmap.
- Send an initial commit only when an output is about to be enabled.
- If an output isn't configured yet, don't commit a buffer.
---
 backend/wayland/output.c  | 32 +++++++++++++++++++-------------
 include/backend/wayland.h |  2 ++
 2 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/backend/wayland/output.c b/backend/wayland/output.c
index 238c1938..c051a764 100644
--- a/backend/wayland/output.c
+++ b/backend/wayland/output.c
@@ -553,6 +553,24 @@ static bool output_commit(struct wlr_output *wlr_output,
 	if (wlr_output->enabled && !pending_enabled) {
 		wl_surface_attach(output->surface, NULL, 0, 0);
 		wl_surface_commit(output->surface);
+
+		output->initialized = false;
+		output->configured = false;
+		output->has_configure_serial = false;
+		output->requested_width = output->requested_height = 0;
+	} else if (output->own_surface && pending_enabled && !output->initialized) {
+		xdg_toplevel_set_title(output->xdg_toplevel, output->title);
+		xdg_toplevel_set_app_id(output->xdg_toplevel, "wlroots");
+		wl_surface_commit(output->surface);
+		output->initialized = true;
+
+		wl_display_flush(output->backend->remote_display);
+		while (!output->configured) {
+			if (wl_event_loop_dispatch(output->backend->event_loop, -1) == -1) {
+				wlr_log(WLR_ERROR, "wl_event_loop_dispatch() failed");
+				return false;
+			}
+		}
 	}
 
 	if (state->committed & WLR_OUTPUT_STATE_BUFFER) {
@@ -908,25 +926,13 @@ struct wlr_output *wlr_wl_output_create(struct wlr_backend *wlr_backend) {
 		goto error;
 	}
 
-	xdg_toplevel_set_title(output->xdg_toplevel, output->title);
-	xdg_toplevel_set_app_id(output->xdg_toplevel, "wlroots");
-
 	xdg_surface_add_listener(output->xdg_surface,
 			&xdg_surface_listener, output);
 	xdg_toplevel_add_listener(output->xdg_toplevel,
 			&xdg_toplevel_listener, output);
-	wl_surface_commit(output->surface);
 
 	wl_display_flush(backend->remote_display);
 
-	while (!output->configured) {
-		int ret = wl_event_loop_dispatch(backend->event_loop, -1);
-		if (ret < 0) {
-			wlr_log(WLR_ERROR, "wl_event_loop_dispatch() failed");
-			goto error;
-		}
-	}
-
 	output_start(output);
 
 	// TODO: let the compositor do this bit
@@ -962,7 +968,7 @@ void wlr_wl_output_set_title(struct wlr_output *output, const char *title) {
 	struct wlr_wl_output *wl_output = get_wl_output_from_output(output);
 	assert(wl_output->xdg_toplevel != NULL);
 
-	if (update_title(wl_output, title)) {
+	if (update_title(wl_output, title) && wl_output->initialized) {
 		xdg_toplevel_set_title(wl_output->xdg_toplevel, wl_output->title);
 		wl_display_flush(wl_output->backend->remote_display);
 	}
diff --git a/include/backend/wayland.h b/include/backend/wayland.h
index 4f9f382b..9a5f7b2c 100644
--- a/include/backend/wayland.h
+++ b/include/backend/wayland.h
@@ -99,6 +99,8 @@ struct wlr_wl_output {
 	bool has_configure_serial;
 	bool configured;
 
+	bool initialized;
+
 	uint32_t enter_serial;
 
 	struct {