From ee56428b642d8f75350ae2698706c1b88898acf5 Mon Sep 17 00:00:00 2001 From: Brian Ashworth Date: Wed, 6 Feb 2019 13:18:46 -0500 Subject: [PATCH] Clarify error for options and positional args When both options and positional arguments are given, sway would print the error `Don't use options with the IPC client`. Over the past several months, it seems like users are including this error message in issues instead of a debug log due to not understanding that the error message means there is an issue with their command. This makes the error message more verbose and will hopefully make it so more users understand that the message is not a bug in sway, but with the command used. --- sway/main.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sway/main.c b/sway/main.c index 67d0f799..12f92bd8 100644 --- a/sway/main.c +++ b/sway/main.c @@ -320,7 +320,13 @@ int main(int argc, char **argv) { if (optind < argc) { // Behave as IPC client if (optind != 1) { - sway_log(SWAY_ERROR, "Don't use options with the IPC client"); + sway_log(SWAY_ERROR, + "Detected both options and positional arguments. If you " + "are trying to use the IPC client, options are not " + "supported. Otherwise, check the provided arguments for " + "issues. See `man 1 sway` or `sway -h` for usage. If you " + "are trying to generate a debug log, use " + "`sway -d 2>sway.log`."); exit(EXIT_FAILURE); } if (!drop_permissions()) {