From de219f6bec432e98e419591f6accd516402c0182 Mon Sep 17 00:00:00 2001 From: "S. Christoffer Eliesen" Date: Fri, 18 Dec 2015 15:30:46 +0100 Subject: [PATCH] swaybar: ipc_update_ws: Fix memory corruption. json_object_object_get_ex does not require json_object_put according to docs, this should fix the random crashes. --- swaybar/main.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/swaybar/main.c b/swaybar/main.c index c0a24bcf..f9387b3c 100644 --- a/swaybar/main.c +++ b/swaybar/main.c @@ -135,10 +135,6 @@ void ipc_update_workspaces() { int i; for (i = 0; i < json_object_array_length(results); ++i) { json_object *ws_json = json_object_array_get_idx(results, i); - if (!ws_json) { - // wat - continue; - } json_object *num, *name, *visible, *focused, *out, *urgent; json_object_object_get_ex(ws_json, "num", &num); json_object_object_get_ex(ws_json, "name", &name); @@ -156,14 +152,6 @@ void ipc_update_workspaces() { ws->urgent = json_object_get_boolean(urgent); list_add(workspaces, ws); } - - json_object_put(num); - json_object_put(name); - json_object_put(visible); - json_object_put(focused); - json_object_put(out); - json_object_put(urgent); - json_object_put(ws_json); } json_object_put(results);