From 710f27d0d2a33e937d5b8dd8c9342b19fa04ebe9 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 29 Jul 2018 10:33:21 +0100
Subject: [PATCH 01/14] commands: allow "first", "last", "newest" and "recent"
 as values for urgent criteria

---
 sway/criteria.c | 11 ++++++++---
 sway/sway.5.scd |  3 ++-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/sway/criteria.c b/sway/criteria.c
index 39d300ea..dd995c4b 100644
--- a/sway/criteria.c
+++ b/sway/criteria.c
@@ -452,13 +452,18 @@ static bool parse_token(struct criteria *criteria, char *name, char *value) {
 		criteria->tiling = true;
 		break;
 	case T_URGENT:
-		if (strcmp(effective_value, "latest") == 0) {
+		if (strcmp(effective_value, "latest") == 0 ||
+				strcmp(effective_value, "newest") == 0 ||
+				strcmp(effective_value, "last") == 0 ||
+				strcmp(effective_value, "recent") == 0) {
 			criteria->urgent = 'l';
-		} else if (strcmp(effective_value, "oldest") == 0) {
+		} else if (strcmp(effective_value, "oldest") == 0 ||
+				strcmp(effective_value, "first") == 0) {
 			criteria->urgent = 'o';
 		} else {
 			error =
-				strdup("The value for 'urgent' must be 'latest' or 'oldest'");
+				strdup("The value for 'urgent' must be 'first', 'last', "
+						"'latest', 'newest', 'oldest' or 'recent'");
 		}
 		break;
 	case T_WORKSPACE:
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index 82df38e3..2d35f5d0 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -612,7 +612,8 @@ The following attributes may be matched with:
 	currently focused window.
 
 *urgent*
-	Compares the urgent state of the window. Can be "latest" or "oldest".
+	Compares the urgent state of the window. Can be "first", "last", "latest",
+	"newest", "oldest" or "recent".
 
 *window\_role*
 	Compare against the window role (WM\_WINDOW\_ROLE). Can be a regular

From 11ac66d6fef118077731fccdaecc350257b8942a Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 29 Jul 2018 11:16:28 +0100
Subject: [PATCH 02/14] commands: allow __focused__ for con_id criterion

---
 sway/criteria.c | 15 ++++++++++++---
 sway/sway.5.scd |  4 +++-
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/sway/criteria.c b/sway/criteria.c
index dd995c4b..2fa9878b 100644
--- a/sway/criteria.c
+++ b/sway/criteria.c
@@ -361,8 +361,17 @@ static char *get_focused_prop(enum criteria_token token) {
 			}
 		}
 		break;
-	case T_CON_ID: // These do not support __focused__
-	case T_CON_MARK:
+	case T_CON_ID:
+		if (view->swayc == NULL) {
+			return NULL;
+		}
+		size_t id = view->swayc->id;
+		int len = snprintf(NULL, 0, "%zu", id) + 1;
+		char *id_str = malloc(len);
+		snprintf(id_str, len, "%zu", id);
+		value = id_str;
+		break;
+	case T_CON_MARK: // These do not support __focused__
 	case T_FLOATING:
 #ifdef HAVE_XWAYLAND
 	case T_ID:
@@ -425,7 +434,7 @@ static bool parse_token(struct criteria *criteria, char *name, char *value) {
 	case T_CON_ID:
 		criteria->con_id = strtoul(effective_value, &endptr, 10);
 		if (*endptr != 0) {
-			error = strdup("The value for 'con_id' should be numeric");
+			error = strdup("The value for 'con_id' should be '__focused__' or numeric");
 		}
 		break;
 	case T_CON_MARK:
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index 2d35f5d0..b639653a 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -582,7 +582,9 @@ The following attributes may be matched with:
 	the currently focused window.
 
 *con\_id*
-	Compare against the internal container ID, which you can find via IPC.
+	Compare against the internal container ID, which you can find via IPC. If
+	value is \_\_focused\_\_, then the id must be the same as that of the
+	currently focused window.
 
 *con\_mark*
 	Compare against the window marks. Can be a regular expression.

From be64c466245d4c537a70484abfe21adc9d60f3c5 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 29 Jul 2018 12:27:34 +0100
Subject: [PATCH 03/14] commands: complete layout implementation

---
 sway/commands/layout.c | 76 +++++++++++++++++++++++++++++++++---------
 sway/sway.5.scd        | 12 +++++--
 2 files changed, 70 insertions(+), 18 deletions(-)

diff --git a/sway/commands/layout.c b/sway/commands/layout.c
index c446f1f9..ec170591 100644
--- a/sway/commands/layout.c
+++ b/sway/commands/layout.c
@@ -1,3 +1,4 @@
+#include <stdbool.h>
 #include <string.h>
 #include <strings.h>
 #include "sway/commands.h"
@@ -5,6 +6,26 @@
 #include "sway/tree/container.h"
 #include "log.h"
 
+static bool parse_layout_string(char *s, enum sway_container_layout *ptr) {
+	if (strcasecmp(s, "splith") == 0) {
+		*ptr = L_HORIZ;
+	} else if (strcasecmp(s, "splitv") == 0) {
+		*ptr = L_VERT;
+	} else if (strcasecmp(s, "tabbed") == 0) {
+		*ptr = L_TABBED;
+	} else if (strcasecmp(s, "stacking") == 0) {
+		*ptr = L_STACKED;
+	} else {
+		return false;
+	}
+	return true;
+}
+
+static const char* expected_syntax =
+	"Expected 'layout default|tabbed|stacking|splitv|splith' or "
+	"'layout toggle [split|all]' or "
+	"'layout toggle [split|tabbed|stacking|splitv|splith] [split|tabbed|stacking|splitv|splith]...'";
+
 struct cmd_results *cmd_layout(int argc, char **argv) {
 	struct cmd_results *error = NULL;
 	if ((error = checkarg(argc, "layout", EXPECTED_MORE_THAN, 0))) {
@@ -23,30 +44,55 @@ struct cmd_results *cmd_layout(int argc, char **argv) {
 
 	if (strcasecmp(argv[0], "default") == 0) {
 		parent->layout = parent->prev_layout;
-		if (parent->layout == L_NONE) {
-			parent->layout = container_get_default_layout(parent);
-		}
 	} else {
 		if (parent->layout != L_TABBED && parent->layout != L_STACKED) {
 			parent->prev_layout = parent->layout;
 		}
 
-		if (strcasecmp(argv[0], "splith") == 0) {
-			parent->layout = L_HORIZ;
-		} else if (strcasecmp(argv[0], "splitv") == 0) {
-			parent->layout = L_VERT;
-		} else if (strcasecmp(argv[0], "tabbed") == 0) {
-			parent->layout = L_TABBED;
-		} else if (strcasecmp(argv[0], "stacking") == 0) {
-			parent->layout = L_STACKED;
-		} else if (strcasecmp(argv[0], "toggle") == 0 && argc == 2 && strcasecmp(argv[1], "split") == 0) {
-			if (parent->layout == L_HORIZ) {
-				parent->layout = L_VERT;
+		bool assigned_directly = parse_layout_string(argv[0], &parent->layout);
+		if (!assigned_directly && strcasecmp(argv[0], "toggle") == 0) {
+			if (argc == 1) {
+				parent->layout =
+					parent->layout == L_STACKED ? L_TABBED :
+					parent->layout == L_TABBED ? parent->prev_layout : L_STACKED;
+			} else if (argc == 2) {
+				if (strcasecmp(argv[1], "all") == 0) {
+					parent->layout =
+						parent->layout == L_HORIZ ? L_VERT :
+						parent->layout == L_VERT ? L_STACKED :
+						parent->layout == L_STACKED ? L_TABBED : L_HORIZ;
+				} else if (strcasecmp(argv[1], "split") == 0) {
+					parent->layout = parent->layout == L_VERT ? L_HORIZ : L_VERT;
+				} else {
+					return cmd_results_new(CMD_INVALID, "layout", expected_syntax);
+				}
 			} else {
-				parent->layout = L_HORIZ;
+				bool valid;
+				enum sway_container_layout parsed_layout;
+				int curr = 1;
+				for (; curr < argc; curr++) {
+					valid = parse_layout_string(argv[curr], &parsed_layout);
+					if (valid && parsed_layout == parent->layout) {
+						break;
+					}
+				}
+				for (int i = curr + 1; i != curr; ++i) {
+					// cycle round to find next valid layout
+					if (i >= argc) {
+						i = 1;
+					}
+					if (parse_layout_string(argv[i], &parent->layout)) {
+						break;
+					} // invalid layout strings are silently ignored
+				}
 			}
+		} else {
+			return cmd_results_new(CMD_INVALID, "layout", expected_syntax);
 		}
 	}
+	if (parent->layout == L_NONE) {
+		parent->layout = container_get_default_layout(parent);
+	}
 
 	container_notify_subtree_changed(parent);
 	arrange_windows(parent);
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index b639653a..a580c7d6 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -111,11 +111,17 @@ They are expected to be used with *bindsym* or at runtime through *swaymsg*(1).
 *fullscreen*
 	Toggles fullscreen for the focused view.
 
-*layout* splith|splitv|stacking|tabbed
+*layout* default|splith|splitv|stacking|tabbed
 	Sets the layout mode of the focused container.
 
-*layout* toggle split
-	Switches the focused container between the splitv and splith layouts.
+*layout* toggle [split|all]
+	Cycles the layout mode of the focused container though a preset list of
+	layouts. If no argument is given, then it cycles through stacking, tabbed
+	and the last split layout. If "split" is given, then it cycles through
+	splith and splitv. If "all" is given, then it cycles through every layout.
+
+*layout* toggle [split|tabbed|stacking|splitv|splith] [split|tabbed|stacking|splitv|splith]...
+	Cycles the layout mode of the focused container through a list of layouts.
 
 *move* left|right|up|down [<px>]
 	Moves the focused container in the direction specified. If the container,

From 69e1a421fc2ccecd93f79c9dd0537671138bb0a9 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Tue, 31 Jul 2018 11:38:34 +0100
Subject: [PATCH 04/14] commands: complete move implementation

---
 include/sway/tree/view.h |   5 ++
 sway/commands/move.c     | 138 +++++++++++++++++++++------------------
 sway/sway.5.scd          |  17 +++--
 sway/tree/view.c         |   9 +++
 4 files changed, 103 insertions(+), 66 deletions(-)

diff --git a/include/sway/tree/view.h b/include/sway/tree/view.h
index 37fd02bc..4a3f01e7 100644
--- a/include/sway/tree/view.h
+++ b/include/sway/tree/view.h
@@ -315,6 +315,11 @@ void view_update_title(struct sway_view *view, bool force);
  */
 void view_execute_criteria(struct sway_view *view);
 
+/**
+ * Find any view that has the given mark and return it.
+ */
+struct sway_view *view_find_mark(char *mark);
+
 /**
  * Find any view that has the given mark and remove the mark from the view.
  * Returns true if it matched a view.
diff --git a/sway/commands/move.c b/sway/commands/move.c
index 841da4c4..b80ce936 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -20,6 +20,7 @@ static const char* expected_syntax =
 	"Expected 'move <left|right|up|down> <[px] px>' or "
 	"'move <container|window> to workspace <name>' or "
 	"'move <container|window|workspace> to output <name|direction>' or "
+	"'move <container|window> to mark <mark>' or "
 	"'move position mouse'";
 
 static struct sway_container *output_in_direction(const char *direction,
@@ -54,19 +55,27 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 	if ((error = checkarg(argc, "move container/window",
 				EXPECTED_AT_LEAST, 4))) {
 		return error;
-	} else if (strcasecmp(argv[1], "to") == 0
-			&& strcasecmp(argv[2], "workspace") == 0) {
-		// move container to workspace x
-		if (current->type == C_WORKSPACE) {
-			if (current->children->length == 0) {
-				return cmd_results_new(CMD_FAILURE, "move",
-						"Can't move an empty workspace");
-			}
-			current = container_wrap_children(current);
-		} else if (current->type != C_CONTAINER && current->type != C_VIEW) {
+	}
+
+	if (current->type == C_WORKSPACE) {
+		if (current->children->length == 0) {
 			return cmd_results_new(CMD_FAILURE, "move",
-					"Can only move containers and views.");
+					"Can't move an empty workspace");
 		}
+		current = container_wrap_children(current);
+	} else if (current->type != C_CONTAINER && current->type != C_VIEW) {
+		return cmd_results_new(CMD_FAILURE, "move",
+				"Can only move containers and views.");
+	}
+
+	struct sway_container *old_parent = current->parent;
+	struct sway_container *old_ws = container_parent(current, C_WORKSPACE);
+	struct sway_container *destination = NULL;
+
+	// determine destination
+	if (strcasecmp(argv[1], "to") == 0
+			&& strcasecmp(argv[2], "workspace") == 0) {
+		// move container to workspace x
 		struct sway_container *ws;
 		char *ws_name = NULL;
 		if (argc == 5 && strcasecmp(argv[3], "number") == 0) {
@@ -80,8 +89,7 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 
 		if (config->auto_back_and_forth && prev_workspace_name) {
 			// auto back and forth move
-			struct sway_container *curr_ws = container_parent(current, C_WORKSPACE);
-			if (curr_ws->name && strcmp(curr_ws->name, ws_name) == 0) {
+			if (old_ws->name && strcmp(old_ws->name, ws_name) == 0) {
 				// if target workspace is the current one
 				free(ws_name);
 				ws_name = strdup(prev_workspace_name);
@@ -93,63 +101,50 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 			ws = workspace_create(NULL, ws_name);
 		}
 		free(ws_name);
-		struct sway_container *old_parent = current->parent;
-		struct sway_container *old_ws = container_parent(current, C_WORKSPACE);
-		struct sway_container *destination = seat_get_focus_inactive(
-				config->handler_context.seat, ws);
-		container_move_to(current, destination);
-		struct sway_container *focus = seat_get_focus_inactive(
-				config->handler_context.seat, old_parent);
-		seat_set_focus_warp(config->handler_context.seat, focus, true, false);
-		container_reap_empty(old_parent);
-		container_reap_empty(destination->parent);
-
-		// TODO: Ideally we would arrange the surviving parent after reaping,
-		// but container_reap_empty does not return it, so we arrange the
-		// workspace instead.
-		arrange_windows(old_ws);
-		arrange_windows(destination->parent);
 
-		return cmd_results_new(CMD_SUCCESS, NULL, NULL);
+		destination = seat_get_focus_inactive(config->handler_context.seat, ws);
 	} else if (strcasecmp(argv[1], "to") == 0
 			&& strcasecmp(argv[2], "output") == 0) {
-		if (current->type == C_WORKSPACE) {
-			// TODO: Wrap children in a container and move that
-			return cmd_results_new(CMD_FAILURE, "move", "Unimplemented");
-		} else if (current->type != C_CONTAINER
-				&& current->type != C_VIEW) {
-			return cmd_results_new(CMD_FAILURE, "move",
-					"Can only move containers and views.");
-		}
 		struct sway_container *source = container_parent(current, C_OUTPUT);
-		struct sway_container *destination = output_in_direction(argv[3],
+		struct sway_container *dest_output = output_in_direction(argv[3],
 				source->sway_output->wlr_output, current->x, current->y);
-		if (!destination) {
+		if (!dest_output) {
 			return cmd_results_new(CMD_FAILURE, "move workspace",
 				"Can't find output with name/direction '%s'", argv[3]);
 		}
-		struct sway_container *focus = seat_get_focus_inactive(
-				config->handler_context.seat, destination);
-		if (!focus) {
+		destination = seat_get_focus_inactive(
+				config->handler_context.seat, dest_output);
+		if (!destination) {
 			// We've never been to this output before
-			focus = destination->children->items[0];
+			destination = dest_output->children->items[0];
 		}
-		struct sway_container *old_parent = current->parent;
-		struct sway_container *old_ws = container_parent(current, C_WORKSPACE);
-		container_move_to(current, focus);
-		seat_set_focus_warp(config->handler_context.seat, old_parent, true, false);
-		container_reap_empty(old_parent);
-		container_reap_empty(focus->parent);
+	} else if (strcasecmp(argv[1], "to") == 0
+			&& strcasecmp(argv[2], "mark") == 0) {
+		struct sway_view *dest_view = view_find_mark(argv[3]);
+		if (dest_view == NULL) {
+			return cmd_results_new(CMD_FAILURE, "move",
+					"Mark '%s' not found", argv[3]);
+		}
+		destination = dest_view->swayc;
+	} else {
+		return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+	}
 
-		// TODO: Ideally we would arrange the surviving parent after reaping,
-		// but container_reap_empty does not return it, so we arrange the
-		// workspace instead.
-		arrange_windows(old_ws);
-		arrange_windows(focus->parent);
+	// move container, arrange windows and return focus
+	container_move_to(current, destination);
+	struct sway_container *focus =
+		seat_get_focus_inactive(config->handler_context.seat, old_parent);
+	seat_set_focus_warp(config->handler_context.seat, focus, true, false);
+	container_reap_empty(old_parent);
+	container_reap_empty(destination->parent);
 
-		return cmd_results_new(CMD_SUCCESS, NULL, NULL);
-	}
-	return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+	// TODO: Ideally we would arrange the surviving parent after reaping,
+	// but container_reap_empty does not return it, so we arrange the
+	// workspace instead.
+	arrange_windows(old_ws);
+	arrange_windows(destination->parent);
+
+	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 }
 
 static struct cmd_results *cmd_move_workspace(struct sway_container *current,
@@ -243,8 +238,8 @@ static struct cmd_results *move_in_direction(struct sway_container *container,
 }
 
 static const char* expected_position_syntax =
-	"Expected 'move [absolute] position <x> <y>' or "
-	"'move [absolute] position mouse'";
+	"Expected 'move [absolute] position <x> [px] <y> [px]' or "
+	"'move [absolute] position center|mouse'";
 
 static struct cmd_results *move_to_position(struct sway_container *container,
 		int argc, char **argv) {
@@ -279,10 +274,18 @@ static struct cmd_results *move_to_position(struct sway_container *container,
 		double ly = seat->cursor->cursor->y - container->height / 2;
 		container_floating_move_to(container, lx, ly);
 		return cmd_results_new(CMD_SUCCESS, NULL, NULL);
+	} else if (strcmp(argv[0], "center") == 0) {
+		struct sway_container *ws = container_parent(container, C_WORKSPACE);
+		double lx = ws->x + (ws->width - container->width) / 2;
+		double ly = ws->y + (ws->height - container->height) / 2;
+		container_floating_move_to(container, lx, ly);
+		return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 	}
-	if (argc != 2) {
+
+	if (argc < 2) {
 		return cmd_results_new(CMD_FAILURE, "move", expected_position_syntax);
 	}
+
 	double lx, ly;
 	char *inv;
 	lx = (double)strtol(argv[0], &inv, 10);
@@ -290,11 +293,22 @@ static struct cmd_results *move_to_position(struct sway_container *container,
 		return cmd_results_new(CMD_FAILURE, "move",
 				"Invalid position specified");
 	}
+	if (strcmp(argv[1], "px") == 0) {
+		--argc;
+		++argv;
+	}
+
+	if (argc > 3) {
+		return cmd_results_new(CMD_FAILURE, "move", expected_position_syntax);
+	}
+
 	ly = (double)strtol(argv[1], &inv, 10);
-	if (*inv != '\0' && strcasecmp(inv, "px") != 0) {
+	if ((*inv != '\0' && strcasecmp(inv, "px") != 0) ||
+			(argc == 3 && strcmp(argv[2], "px") != 0)) {
 		return cmd_results_new(CMD_FAILURE, "move",
 				"Invalid position specified");
 	}
+
 	container_floating_move_to(container, lx, ly);
 	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 }
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index a580c7d6..8083106b 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -123,18 +123,27 @@ They are expected to be used with *bindsym* or at runtime through *swaymsg*(1).
 *layout* toggle [split|tabbed|stacking|splitv|splith] [split|tabbed|stacking|splitv|splith]...
 	Cycles the layout mode of the focused container through a list of layouts.
 
-*move* left|right|up|down [<px>]
+*move* left|right|up|down [<px> px]
 	Moves the focused container in the direction specified. If the container,
 	the optional _px_ argument specifies how many pixels to move the container.
 	If unspecified, the default is 10 pixels. Pixels are ignored when moving
 	tiled containers.
 
+*move* [absolute] position <pos_x> [px] <pos_y> [px]
+	Moves the focused container to the specified position.
+
+*move* [absolute] position center|mouse
+	Moves the focused container to be centered on the workspace or mouse.
+
+*move* container|window to mark <mark>
+	Moves the focused container to the specified mark.
+
 *move* container|window to workspace <name>
 	Moves the focused container to the specified workspace.
 
-*move* container|window to workspace prev|next
-	Moves the focused container to the previous or next workspace on this
-	output, or if no workspaces remain, the previous or next output.
+*move* container|window to workspace prev|next|current
+	Moves the focused container to the previous, next or current workspace on
+	this output, or if no workspaces remain, the previous or next output.
 
 *move* container|window to workspace prev\_on\_output|next\_on\_output
 	Moves the focused container to the previous or next workspace on this
diff --git a/sway/tree/view.c b/sway/tree/view.c
index 9465b3a1..48bd7ac0 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -891,6 +891,15 @@ static bool find_by_mark_iterator(struct sway_container *con,
 	return con->type == C_VIEW && view_has_mark(con->sway_view, mark);
 }
 
+struct sway_view *view_find_mark(char *mark) {
+	struct sway_container *container = container_find(&root_container,
+		find_by_mark_iterator, mark);
+	if (!container) {
+		return NULL;
+	}
+	return container->sway_view;
+}
+
 bool view_find_and_unmark(char *mark) {
 	struct sway_container *container = container_find(&root_container,
 		find_by_mark_iterator, mark);

From 3a980857cba80719e70ee3960b5b3b12923fda81 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Wed, 1 Aug 2018 16:02:56 +0100
Subject: [PATCH 05/14] commands: better type for con_id string length

---
 sway/criteria.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sway/criteria.c b/sway/criteria.c
index 2fa9878b..9077aa9b 100644
--- a/sway/criteria.c
+++ b/sway/criteria.c
@@ -366,9 +366,9 @@ static char *get_focused_prop(enum criteria_token token) {
 			return NULL;
 		}
 		size_t id = view->swayc->id;
-		int len = snprintf(NULL, 0, "%zu", id) + 1;
-		char *id_str = malloc(len);
-		snprintf(id_str, len, "%zu", id);
+		size_t id_size = snprintf(NULL, 0, "%zu", id) + 1;
+		char *id_str = malloc(id_size);
+		snprintf(id_str, id_size, "%zu", id);
 		value = id_str;
 		break;
 	case T_CON_MARK: // These do not support __focused__

From 356063b6c084a7c2d4e3e654fe48ec79a102294b Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Wed, 1 Aug 2018 16:03:37 +0100
Subject: [PATCH 06/14] commands: fix layout implementation (also better name
 for previous split layout)

---
 include/sway/tree/container.h |  2 +-
 sway/commands/layout.c        | 43 +++++++++++++++++++++--------------
 sway/tree/layout.c            |  4 ++--
 sway/tree/workspace.c         |  2 +-
 4 files changed, 30 insertions(+), 21 deletions(-)

diff --git a/include/sway/tree/container.h b/include/sway/tree/container.h
index 44ff9f7d..16a180f8 100644
--- a/include/sway/tree/container.h
+++ b/include/sway/tree/container.h
@@ -113,7 +113,7 @@ struct sway_container {
 
 	enum sway_container_type type;
 	enum sway_container_layout layout;
-	enum sway_container_layout prev_layout;
+	enum sway_container_layout prev_split_layout;
 
 	bool is_sticky;
 
diff --git a/sway/commands/layout.c b/sway/commands/layout.c
index ec170591..f4e4dda9 100644
--- a/sway/commands/layout.c
+++ b/sway/commands/layout.c
@@ -42,19 +42,16 @@ struct cmd_results *cmd_layout(int argc, char **argv) {
 		parent = parent->parent;
 	}
 
-	if (strcasecmp(argv[0], "default") == 0) {
-		parent->layout = parent->prev_layout;
-	} else {
-		if (parent->layout != L_TABBED && parent->layout != L_STACKED) {
-			parent->prev_layout = parent->layout;
-		}
-
-		bool assigned_directly = parse_layout_string(argv[0], &parent->layout);
-		if (!assigned_directly && strcasecmp(argv[0], "toggle") == 0) {
+	enum sway_container_layout prev = parent->layout;
+	bool assigned_directly = parse_layout_string(argv[0], &parent->layout);
+	if (!assigned_directly) {
+		if (strcasecmp(argv[0], "default") == 0) {
+			parent->layout = parent->prev_split_layout;
+		} else if (strcasecmp(argv[0], "toggle") == 0) {
 			if (argc == 1) {
 				parent->layout =
 					parent->layout == L_STACKED ? L_TABBED :
-					parent->layout == L_TABBED ? parent->prev_layout : L_STACKED;
+					parent->layout == L_TABBED ? parent->prev_split_layout : L_STACKED;
 			} else if (argc == 2) {
 				if (strcasecmp(argv[1], "all") == 0) {
 					parent->layout =
@@ -62,17 +59,20 @@ struct cmd_results *cmd_layout(int argc, char **argv) {
 						parent->layout == L_VERT ? L_STACKED :
 						parent->layout == L_STACKED ? L_TABBED : L_HORIZ;
 				} else if (strcasecmp(argv[1], "split") == 0) {
-					parent->layout = parent->layout == L_VERT ? L_HORIZ : L_VERT;
+					parent->layout =
+						parent->layout == L_HORIZ ? L_VERT :
+						parent->layout == L_VERT ? L_HORIZ : parent->prev_split_layout;
 				} else {
 					return cmd_results_new(CMD_INVALID, "layout", expected_syntax);
 				}
 			} else {
-				bool valid;
 				enum sway_container_layout parsed_layout;
 				int curr = 1;
 				for (; curr < argc; curr++) {
-					valid = parse_layout_string(argv[curr], &parsed_layout);
-					if (valid && parsed_layout == parent->layout) {
+					bool valid = parse_layout_string(argv[curr], &parsed_layout);
+					if ((valid && parsed_layout == parent->layout) ||
+							(strcmp(argv[curr], "split") == 0 &&
+							(parent->layout == L_VERT || parent->layout == L_HORIZ))) {
 						break;
 					}
 				}
@@ -83,6 +83,11 @@ struct cmd_results *cmd_layout(int argc, char **argv) {
 					}
 					if (parse_layout_string(argv[i], &parent->layout)) {
 						break;
+					} else if (strcmp(argv[i], "split") == 0) {
+						parent->layout =
+							parent->layout == L_HORIZ ? L_VERT :
+							parent->layout == L_VERT ? L_HORIZ : parent->prev_split_layout;
+						break;
 					} // invalid layout strings are silently ignored
 				}
 			}
@@ -93,9 +98,13 @@ struct cmd_results *cmd_layout(int argc, char **argv) {
 	if (parent->layout == L_NONE) {
 		parent->layout = container_get_default_layout(parent);
 	}
-
-	container_notify_subtree_changed(parent);
-	arrange_windows(parent);
+	if (prev != parent->layout) {
+		if (prev != L_TABBED && prev != L_STACKED) {
+			parent->prev_split_layout = prev;
+		}
+		container_notify_subtree_changed(parent);
+		arrange_windows(parent);
+	}
 
 	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 }
diff --git a/sway/tree/layout.c b/sway/tree/layout.c
index 07de9664..28cdc71e 100644
--- a/sway/tree/layout.c
+++ b/sway/tree/layout.c
@@ -859,7 +859,7 @@ struct sway_container *container_split(struct sway_container *child,
 	}
 	if (child->type == C_WORKSPACE && child->children->length == 0) {
 		// Special case: this just behaves like splitt
-		child->prev_layout = child->layout;
+		child->prev_split_layout = child->layout;
 		child->layout = layout;
 		return child;
 	}
@@ -870,7 +870,7 @@ struct sway_container *container_split(struct sway_container *child,
 
 	remove_gaps(child);
 
-	cont->prev_layout = L_NONE;
+	cont->prev_split_layout = L_NONE;
 	cont->width = child->width;
 	cont->height = child->height;
 	cont->x = child->x;
diff --git a/sway/tree/workspace.c b/sway/tree/workspace.c
index cc225e79..250d5ba7 100644
--- a/sway/tree/workspace.c
+++ b/sway/tree/workspace.c
@@ -59,7 +59,7 @@ struct sway_container *workspace_create(struct sway_container *output,
 	workspace->width = output->width;
 	workspace->height = output->height;
 	workspace->name = !name ? NULL : strdup(name);
-	workspace->prev_layout = L_NONE;
+	workspace->prev_split_layout = L_NONE;
 	workspace->layout = container_get_default_layout(output);
 
 	struct sway_workspace *swayws = calloc(1, sizeof(struct sway_workspace));

From 85ae121caad02265b95ecea66fa864607575eb31 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 5 Aug 2018 00:05:48 +0100
Subject: [PATCH 07/14] commands: complete workspace implementation

Allow optional --no-auto-back-and-forth flag, as well as refactoring some logic
---
 include/sway/tree/workspace.h |  4 ++-
 sway/commands/workspace.c     | 54 +++++++++++++++--------------------
 sway/sway.5.scd               |  5 +++-
 sway/tree/workspace.c         | 42 ++++++++++++++++++---------
 4 files changed, 59 insertions(+), 46 deletions(-)

diff --git a/include/sway/tree/workspace.h b/include/sway/tree/workspace.h
index 3337f2c8..239cbbdb 100644
--- a/include/sway/tree/workspace.h
+++ b/include/sway/tree/workspace.h
@@ -1,6 +1,7 @@
 #ifndef _SWAY_WORKSPACE_H
 #define _SWAY_WORKSPACE_H
 
+#include <stdbool.h>
 #include "sway/tree/container.h"
 
 struct sway_view;
@@ -17,7 +18,8 @@ extern char *prev_workspace_name;
 
 char *workspace_next_name(const char *output_name);
 
-bool workspace_switch(struct sway_container *workspace);
+bool workspace_switch(struct sway_container *workspace,
+		bool no_auto_back_and_forth);
 
 struct sway_container *workspace_by_number(const char* name);
 
diff --git a/sway/commands/workspace.c b/sway/commands/workspace.c
index e8b37182..f32ede1e 100644
--- a/sway/commands/workspace.c
+++ b/sway/commands/workspace.c
@@ -17,17 +17,6 @@ struct cmd_results *cmd_workspace(int argc, char **argv) {
 
 	int output_location = -1;
 
-	struct sway_container *current_container = config->handler_context.current_container;
-	struct sway_container *old_workspace = NULL, *old_output = NULL;
-	if (current_container) {
-		if (current_container->type == C_WORKSPACE) {
-			old_workspace = current_container;
-		} else {
-			old_workspace = container_parent(current_container, C_WORKSPACE);
-		}
-		old_output = container_parent(current_container, C_OUTPUT);
-	}
-
 	for (int i = 0; i < argc; ++i) {
 		if (strcasecmp(argv[i], "output") == 0) {
 			output_location = i;
@@ -57,39 +46,42 @@ struct cmd_results *cmd_workspace(int argc, char **argv) {
 		if (config->reading || !config->active) {
 			return cmd_results_new(CMD_DEFER, "workspace", NULL);
 		}
+
+		bool no_auto_back_and_forth = false;
+		while (strcasecmp(argv[0], "--no-auto-back-and-forth") == 0) {
+			no_auto_back_and_forth = true;
+			if ((error = checkarg(--argc, "workspace", EXPECTED_AT_LEAST, 1))) {
+				return error;
+			}
+			++argv;
+		}
+
+
 		struct sway_container *ws = NULL;
 		if (strcasecmp(argv[0], "number") == 0) {
+			if (argc < 2) {
+				cmd_results_new(CMD_INVALID, "workspace",
+						"Expected workspace number");
+			}
 			if (!(ws = workspace_by_number(argv[1]))) {
 				char *name = join_args(argv + 1, argc - 1);
 				ws = workspace_create(NULL, name);
 				free(name);
 			}
-		} else if (strcasecmp(argv[0], "next") == 0) {
-			ws = workspace_next(old_workspace);
-		} else if (strcasecmp(argv[0], "prev") == 0) {
-			ws = workspace_prev(old_workspace);
-		} else if (strcasecmp(argv[0], "next_on_output") == 0) {
-			ws = workspace_output_next(old_output);
-		} else if (strcasecmp(argv[0], "prev_on_output") == 0) {
-			ws = workspace_output_prev(old_output);
-		} else if (strcasecmp(argv[0], "back_and_forth") == 0) {
-			// if auto_back_and_forth is enabled, workspace_switch will swap
-			// the workspaces. If we created prev_workspace here, workspace_switch
-			// would put us back on original workspace.
-			if (config->auto_back_and_forth) {
-				ws = old_workspace;
-			} else if (prev_workspace_name
-					&& !(ws = workspace_by_name(prev_workspace_name))) {
-				ws = workspace_create(NULL, prev_workspace_name);
-			}
 		} else {
 			char *name = join_args(argv, argc);
 			if (!(ws = workspace_by_name(name))) {
-				ws = workspace_create(NULL, name);
+				if (strcasecmp(argv[0], "back_and_forth") == 0) {
+					if (prev_workspace_name) {
+						ws = workspace_create(NULL, prev_workspace_name);
+					}
+				} else {
+					ws = workspace_create(NULL, name);
+				}
 			}
 			free(name);
 		}
-		workspace_switch(ws);
+		workspace_switch(ws, no_auto_back_and_forth);
 	}
 	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 }
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index 8083106b..36ce13df 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -526,7 +526,7 @@ config after the others, or it will be matched instead of the others.
 	state. Using _allow_ or _deny_ controls the window's ability to set itself
 	as urgent. By default, windows are allowed to set their own urgency.
 
-*workspace* [number] <name>
+*workspace* [--no-auto-back-and-forth] [number] <name>
 	Switches to the specified workspace. The string "number" is optional and is
 	used to sort workspaces.
 
@@ -537,6 +537,9 @@ config after the others, or it will be matched instead of the others.
 *workspace* prev\_on\_output|next\_on\_output
 	Switches to the next workspace on the current output.
 
+*workspace* back_and_forth
+	Switches to the previously focused workspace.
+
 *workspace* <name> output <output>
 	Specifies that workspace _name_ should be shown on the specified _output_.
 
diff --git a/sway/tree/workspace.c b/sway/tree/workspace.c
index 250d5ba7..5e20429b 100644
--- a/sway/tree/workspace.c
+++ b/sway/tree/workspace.c
@@ -250,20 +250,35 @@ struct sway_container *workspace_by_name(const char *name) {
 		current_workspace = container_parent(focus, C_WORKSPACE);
 		current_output = container_parent(focus, C_OUTPUT);
 	}
-	if (strcmp(name, "prev") == 0) {
-		return workspace_prev(current_workspace);
-	} else if (strcmp(name, "prev_on_output") == 0) {
-		return workspace_output_prev(current_output);
-	} else if (strcmp(name, "next") == 0) {
-		return workspace_next(current_workspace);
-	} else if (strcmp(name, "next_on_output") == 0) {
-		return workspace_output_next(current_output);
-	} else if (strcmp(name, "current") == 0) {
-		return current_workspace;
+
+	char *name_cpy = strdup(name);
+	char *first_word = strtok(name_cpy, " ");
+	if (first_word == NULL) {
+		first_word = name_cpy;
+	}
+
+	struct sway_container *ws = NULL;
+	if (strcmp(first_word, "prev") == 0) {
+		ws = workspace_prev(current_workspace);
+	} else if (strcmp(first_word, "prev_on_output") == 0) {
+		ws = workspace_output_prev(current_output);
+	} else if (strcmp(first_word, "next") == 0) {
+		ws = workspace_next(current_workspace);
+	} else if (strcmp(first_word, "next_on_output") == 0) {
+		ws = workspace_output_next(current_output);
+	} else if (strcmp(first_word, "current") == 0) {
+		ws = current_workspace;
+	} else if (strcasecmp(first_word, "back_and_forth") == 0) {
+		if (prev_workspace_name) {
+			ws = container_find(&root_container, _workspace_by_name,
+				(void *)prev_workspace_name);
+		}
 	} else {
-		return container_find(&root_container, _workspace_by_name,
+		ws = container_find(&root_container, _workspace_by_name,
 				(void *)name);
 	}
+	free(name_cpy);
+	return ws;
 }
 
 /**
@@ -364,7 +379,8 @@ struct sway_container *workspace_prev(struct sway_container *current) {
 	return workspace_prev_next_impl(current, false);
 }
 
-bool workspace_switch(struct sway_container *workspace) {
+bool workspace_switch(struct sway_container *workspace,
+		bool no_auto_back_and_forth) {
 	if (!workspace) {
 		return false;
 	}
@@ -379,7 +395,7 @@ bool workspace_switch(struct sway_container *workspace) {
 		active_ws = container_parent(focus, C_WORKSPACE);
 	}
 
-	if (config->auto_back_and_forth
+	if (!no_auto_back_and_forth && config->auto_back_and_forth
 			&& active_ws == workspace
 			&& prev_workspace_name) {
 		struct sway_container *new_ws = workspace_by_name(prev_workspace_name);

From dd48c8a579918f34c6a3441068e6f4b7e753e09c Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 5 Aug 2018 00:16:21 +0100
Subject: [PATCH 08/14] commands: add optional flags to move

---
 sway/commands/move.c | 97 +++++++++++++++++++++++++++++++-------------
 sway/sway.5.scd      | 19 +++++----
 2 files changed, 81 insertions(+), 35 deletions(-)

diff --git a/sway/commands/move.c b/sway/commands/move.c
index b80ce936..d49d6862 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -1,4 +1,5 @@
 #define _XOPEN_SOURCE 500
+#include <stdbool.h>
 #include <string.h>
 #include <strings.h>
 #include <wlr/types/wlr_cursor.h>
@@ -16,12 +17,11 @@
 #include "stringop.h"
 #include "list.h"
 
-static const char* expected_syntax =
+static const char *expected_syntax =
 	"Expected 'move <left|right|up|down> <[px] px>' or "
-	"'move <container|window> to workspace <name>' or "
-	"'move <container|window|workspace> to output <name|direction>' or "
-	"'move <container|window> to mark <mark>' or "
-	"'move position mouse'";
+	"'move [--no-auto-back-and-forth] <container|window> [to] workspace <name>' or "
+	"'move [--no-auto-back-and-forth] <container|window|workspace> [to] output <name|direction>' or "
+	"'move <container|window> [to] mark <mark>'";
 
 static struct sway_container *output_in_direction(const char *direction,
 		struct wlr_output *reference, int ref_lx, int ref_ly) {
@@ -53,7 +53,7 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 		int argc, char **argv) {
 	struct cmd_results *error = NULL;
 	if ((error = checkarg(argc, "move container/window",
-				EXPECTED_AT_LEAST, 4))) {
+				EXPECTED_AT_LEAST, 3))) {
 		return error;
 	}
 
@@ -68,26 +68,52 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 				"Can only move containers and views.");
 	}
 
+	bool no_auto_back_and_forth = false;
+	while (strcasecmp(argv[0], "--no-auto-back-and-forth") == 0) {
+		no_auto_back_and_forth = true;
+		if (--argc < 3) {
+			return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+		}
+		++argv;
+	}
+	while (strcasecmp(argv[1], "--no-auto-back-and-forth") == 0) {
+		no_auto_back_and_forth = true;
+		if (--argc < 3) {
+			return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+		}
+		argv++;
+	}
+
+	while (strcasecmp(argv[1], "to") == 0) {
+		if (--argc < 3) {
+			return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+		}
+		argv++;
+	}
+
 	struct sway_container *old_parent = current->parent;
 	struct sway_container *old_ws = container_parent(current, C_WORKSPACE);
 	struct sway_container *destination = NULL;
 
 	// determine destination
-	if (strcasecmp(argv[1], "to") == 0
-			&& strcasecmp(argv[2], "workspace") == 0) {
+	if (strcasecmp(argv[1], "workspace") == 0) {
 		// move container to workspace x
 		struct sway_container *ws;
 		char *ws_name = NULL;
-		if (argc == 5 && strcasecmp(argv[3], "number") == 0) {
+		if (strcasecmp(argv[2], "number") == 0) {
 			// move "container to workspace number x"
-			ws_name = strdup(argv[4]);
+			if (argc < 4) {
+				return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+			}
+			ws_name = strdup(argv[3]);
 			ws = workspace_by_number(ws_name);
 		} else {
-			ws_name = join_args(argv + 3, argc - 3);
+			ws_name = join_args(argv + 2, argc - 2);
 			ws = workspace_by_name(ws_name);
 		}
 
-		if (config->auto_back_and_forth && prev_workspace_name) {
+		if (!no_auto_back_and_forth && config->auto_back_and_forth &&
+				prev_workspace_name) {
 			// auto back and forth move
 			if (old_ws->name && strcmp(old_ws->name, ws_name) == 0) {
 				// if target workspace is the current one
@@ -98,19 +124,23 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 		}
 
 		if (!ws) {
+			if (strcasecmp(argv[2], "back_and_forth") == 0) {
+				if (prev_workspace_name) {
+					ws = workspace_create(NULL, prev_workspace_name);
+				}
+			}
 			ws = workspace_create(NULL, ws_name);
 		}
 		free(ws_name);
 
 		destination = seat_get_focus_inactive(config->handler_context.seat, ws);
-	} else if (strcasecmp(argv[1], "to") == 0
-			&& strcasecmp(argv[2], "output") == 0) {
+	} else if (strcasecmp(argv[1], "output") == 0) {
 		struct sway_container *source = container_parent(current, C_OUTPUT);
-		struct sway_container *dest_output = output_in_direction(argv[3],
+		struct sway_container *dest_output = output_in_direction(argv[2],
 				source->sway_output->wlr_output, current->x, current->y);
 		if (!dest_output) {
 			return cmd_results_new(CMD_FAILURE, "move workspace",
-				"Can't find output with name/direction '%s'", argv[3]);
+				"Can't find output with name/direction '%s'", argv[2]);
 		}
 		destination = seat_get_focus_inactive(
 				config->handler_context.seat, dest_output);
@@ -118,12 +148,11 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 			// We've never been to this output before
 			destination = dest_output->children->items[0];
 		}
-	} else if (strcasecmp(argv[1], "to") == 0
-			&& strcasecmp(argv[2], "mark") == 0) {
-		struct sway_view *dest_view = view_find_mark(argv[3]);
+	} else if (strcasecmp(argv[1], "mark") == 0) {
+		struct sway_view *dest_view = view_find_mark(argv[2]);
 		if (dest_view == NULL) {
 			return cmd_results_new(CMD_FAILURE, "move",
-					"Mark '%s' not found", argv[3]);
+					"Mark '%s' not found", argv[2]);
 		}
 		destination = dest_view->swayc;
 	} else {
@@ -150,20 +179,29 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 static struct cmd_results *cmd_move_workspace(struct sway_container *current,
 		int argc, char **argv) {
 	struct cmd_results *error = NULL;
-	if ((error = checkarg(argc, "move workspace", EXPECTED_EQUAL_TO, 4))) {
+	if ((error = checkarg(argc, "move workspace", EXPECTED_AT_LEAST, 2))) {
 		return error;
-	} else if (strcasecmp(argv[1], "to") != 0
-			|| strcasecmp(argv[2], "output") != 0) {
+	}
+
+	while (strcasecmp(argv[1], "to") == 0) {
+		if (--argc < 3) {
+			return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+		}
+		++argv;
+	}
+
+	if (strcasecmp(argv[1], "output") != 0) {
 		return cmd_results_new(CMD_INVALID, "move", expected_syntax);
 	}
+
 	struct sway_container *source = container_parent(current, C_OUTPUT);
 	int center_x = current->width / 2 + current->x,
 		center_y = current->height / 2 + current->y;
-	struct sway_container *destination = output_in_direction(argv[3],
+	struct sway_container *destination = output_in_direction(argv[2],
 			source->sway_output->wlr_output, center_x, center_y);
 	if (!destination) {
 		return cmd_results_new(CMD_FAILURE, "move workspace",
-			"Can't find output with name/direction '%s'", argv[3]);
+			"Can't find output with name/direction '%s'", argv[2]);
 	}
 	if (current->type != C_WORKSPACE) {
 		current = container_parent(current, C_WORKSPACE);
@@ -237,7 +275,7 @@ static struct cmd_results *move_in_direction(struct sway_container *container,
 	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
 }
 
-static const char* expected_position_syntax =
+static const char *expected_position_syntax =
 	"Expected 'move [absolute] position <x> [px] <y> [px]' or "
 	"'move [absolute] position center|mouse'";
 
@@ -356,8 +394,11 @@ struct cmd_results *cmd_move(int argc, char **argv) {
 		return move_in_direction(current, MOVE_UP, argc, argv);
 	} else if (strcasecmp(argv[0], "down") == 0) {
 		return move_in_direction(current, MOVE_DOWN, argc, argv);
-	} else if (strcasecmp(argv[0], "container") == 0
-			|| strcasecmp(argv[0], "window") == 0) {
+	} else if ((strcasecmp(argv[0], "container") == 0
+			|| strcasecmp(argv[0], "window") == 0) ||
+			(strcasecmp(argv[0], "--no-auto-back-and-forth") &&
+			(strcasecmp(argv[0], "container") == 0
+			|| strcasecmp(argv[0], "window") == 0))) {
 		return cmd_move_container(current, argc, argv);
 	} else if (strcasecmp(argv[0], "workspace") == 0) {
 		return cmd_move_workspace(current, argc, argv);
diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index 36ce13df..b43cbe8d 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -135,24 +135,29 @@ They are expected to be used with *bindsym* or at runtime through *swaymsg*(1).
 *move* [absolute] position center|mouse
 	Moves the focused container to be centered on the workspace or mouse.
 
-*move* container|window to mark <mark>
+*move* container|window [to] mark <mark>
 	Moves the focused container to the specified mark.
 
-*move* container|window to workspace <name>
-	Moves the focused container to the specified workspace.
+*move* [--no-auto-back-and-forth] container|window [to] workspace [number] <name>
+	Moves the focused container to the specified workspace. The string "number"
+	is optional and is used to match a workspace with the same number, even if
+	it has a different name.
 
-*move* container|window to workspace prev|next|current
+*move* container|window [to] workspace prev|next|current
 	Moves the focused container to the previous, next or current workspace on
 	this output, or if no workspaces remain, the previous or next output.
 
-*move* container|window to workspace prev\_on\_output|next\_on\_output
+*move* container|window [to] workspace prev\_on\_output|next\_on\_output
 	Moves the focused container to the previous or next workspace on this
 	output, wrapping around if already at the first or last workspace.
 
-*move* container|window|workspace to output <name>
+*move* container|window [to] workspace back_and_forth
+	Moves the focused container to previously focused workspace.
+
+*move* container|window|workspace [to] output <name>
 	Moves the focused container or workspace to the specified output.
 
-*move* container|window|workspace to output up|right|down|left
+*move* container|window|workspace [to] output up|right|down|left
 	Moves the focused container or workspace to next output in the specified
 	direction.
 

From 3b1f58e1353f68ea10a3c5325ba4e04fbbe0c6a7 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Sun, 5 Aug 2018 00:27:53 +0100
Subject: [PATCH 09/14] commands: document <criteria> focus

---
 sway/sway.5.scd | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sway/sway.5.scd b/sway/sway.5.scd
index b43cbe8d..73a01152 100644
--- a/sway/sway.5.scd
+++ b/sway/sway.5.scd
@@ -84,6 +84,9 @@ They are expected to be used with *bindsym* or at runtime through *swaymsg*(1).
 *floating* enable|disable|toggle
 	Make focused view floating, non-floating, or the opposite of what it is now.
 
+<criteria> *focus*
+	Moves focus to the container that matches the specified criteria.
+
 *focus* up|right|down|left
 	Moves focus to the next container in the specified direction.
 

From 667b8dcb67d8c3f15b52f59d228bb3146a5cdb30 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Mon, 6 Aug 2018 10:43:09 +0100
Subject: [PATCH 10/14] commands: check for special workspaces in workspace &
 move commands

---
 sway/commands/move.c      | 60 ++++++++++++++++++++++-----------------
 sway/commands/workspace.c | 18 +++++++-----
 sway/tree/workspace.c     | 39 +++++++++----------------
 3 files changed, 59 insertions(+), 58 deletions(-)

diff --git a/sway/commands/move.c b/sway/commands/move.c
index d49d6862..500151f7 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -99,40 +99,48 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 	if (strcasecmp(argv[1], "workspace") == 0) {
 		// move container to workspace x
 		struct sway_container *ws;
-		char *ws_name = NULL;
-		if (strcasecmp(argv[2], "number") == 0) {
-			// move "container to workspace number x"
-			if (argc < 4) {
-				return cmd_results_new(CMD_INVALID, "move", expected_syntax);
+		if (strcasecmp(argv[2], "next") == 0 ||
+				strcasecmp(argv[2], "prev") == 0 ||
+				strcasecmp(argv[2], "next_on_output") == 0 ||
+				strcasecmp(argv[2], "prev_on_output") == 0 ||
+				strcasecmp(argv[2], "back_and_forth") == 0 ||
+				strcasecmp(argv[2], "current") == 0) {
+			ws = workspace_by_name(argv[2]);
+		} else if (strcasecmp(argv[2], "back_and_forth") == 0) {
+			if (!(ws = workspace_by_name(argv[0])) && prev_workspace_name) {
+				ws = workspace_create(NULL, prev_workspace_name);
 			}
-			ws_name = strdup(argv[3]);
-			ws = workspace_by_number(ws_name);
 		} else {
-			ws_name = join_args(argv + 2, argc - 2);
-			ws = workspace_by_name(ws_name);
-		}
-
-		if (!no_auto_back_and_forth && config->auto_back_and_forth &&
-				prev_workspace_name) {
-			// auto back and forth move
-			if (old_ws->name && strcmp(old_ws->name, ws_name) == 0) {
-				// if target workspace is the current one
-				free(ws_name);
-				ws_name = strdup(prev_workspace_name);
+			char *ws_name = NULL;
+			if (strcasecmp(argv[2], "number") == 0) {
+				// move "container to workspace number x"
+				if (argc < 4) {
+					return cmd_results_new(CMD_INVALID, "move",
+							expected_syntax);
+				}
+				ws_name = strdup(argv[3]);
+				ws = workspace_by_number(ws_name);
+			} else {
+				ws_name = join_args(argv + 2, argc - 2);
 				ws = workspace_by_name(ws_name);
 			}
-		}
 
-		if (!ws) {
-			if (strcasecmp(argv[2], "back_and_forth") == 0) {
-				if (prev_workspace_name) {
-					ws = workspace_create(NULL, prev_workspace_name);
+			if (!no_auto_back_and_forth && config->auto_back_and_forth &&
+					prev_workspace_name) {
+				// auto back and forth move
+				if (old_ws->name && strcmp(old_ws->name, ws_name) == 0) {
+					// if target workspace is the current one
+					free(ws_name);
+					ws_name = strdup(prev_workspace_name);
+					ws = workspace_by_name(ws_name);
 				}
 			}
-			ws = workspace_create(NULL, ws_name);
-		}
-		free(ws_name);
 
+			if (!ws) {
+				ws = workspace_create(NULL, ws_name);
+			}
+			free(ws_name);
+		}
 		destination = seat_get_focus_inactive(config->handler_context.seat, ws);
 	} else if (strcasecmp(argv[1], "output") == 0) {
 		struct sway_container *source = container_parent(current, C_OUTPUT);
diff --git a/sway/commands/workspace.c b/sway/commands/workspace.c
index f32ede1e..f5558bb4 100644
--- a/sway/commands/workspace.c
+++ b/sway/commands/workspace.c
@@ -68,16 +68,20 @@ struct cmd_results *cmd_workspace(int argc, char **argv) {
 				ws = workspace_create(NULL, name);
 				free(name);
 			}
+		} else if (strcasecmp(argv[0], "next") == 0 ||
+				strcasecmp(argv[0], "prev") == 0 ||
+				strcasecmp(argv[0], "next_on_output") == 0 ||
+				strcasecmp(argv[0], "prev_on_output") == 0 ||
+				strcasecmp(argv[0], "current") == 0) {
+			ws = workspace_by_name(argv[0]);
+		} else if (strcasecmp(argv[0], "back_and_forth") == 0) {
+			if (!(ws = workspace_by_name(argv[0])) && prev_workspace_name) {
+				ws = workspace_create(NULL, prev_workspace_name);
+			}
 		} else {
 			char *name = join_args(argv, argc);
 			if (!(ws = workspace_by_name(name))) {
-				if (strcasecmp(argv[0], "back_and_forth") == 0) {
-					if (prev_workspace_name) {
-						ws = workspace_create(NULL, prev_workspace_name);
-					}
-				} else {
-					ws = workspace_create(NULL, name);
-				}
+				ws = workspace_create(NULL, name);
 			}
 			free(name);
 		}
diff --git a/sway/tree/workspace.c b/sway/tree/workspace.c
index 5e20429b..3fcad631 100644
--- a/sway/tree/workspace.c
+++ b/sway/tree/workspace.c
@@ -251,34 +251,23 @@ struct sway_container *workspace_by_name(const char *name) {
 		current_output = container_parent(focus, C_OUTPUT);
 	}
 
-	char *name_cpy = strdup(name);
-	char *first_word = strtok(name_cpy, " ");
-	if (first_word == NULL) {
-		first_word = name_cpy;
-	}
-
-	struct sway_container *ws = NULL;
-	if (strcmp(first_word, "prev") == 0) {
-		ws = workspace_prev(current_workspace);
-	} else if (strcmp(first_word, "prev_on_output") == 0) {
-		ws = workspace_output_prev(current_output);
-	} else if (strcmp(first_word, "next") == 0) {
-		ws = workspace_next(current_workspace);
-	} else if (strcmp(first_word, "next_on_output") == 0) {
-		ws = workspace_output_next(current_output);
-	} else if (strcmp(first_word, "current") == 0) {
-		ws = current_workspace;
-	} else if (strcasecmp(first_word, "back_and_forth") == 0) {
-		if (prev_workspace_name) {
-			ws = container_find(&root_container, _workspace_by_name,
-				(void *)prev_workspace_name);
-		}
+	if (strcmp(name, "prev") == 0) {
+		return workspace_prev(current_workspace);
+	} else if (strcmp(name, "prev_on_output") == 0) {
+		return workspace_output_prev(current_output);
+	} else if (strcmp(name, "next") == 0) {
+		return workspace_next(current_workspace);
+	} else if (strcmp(name, "next_on_output") == 0) {
+		return workspace_output_next(current_output);
+	} else if (strcmp(name, "current") == 0) {
+		return current_workspace;
+	} else if (strcasecmp(name, "back_and_forth") == 0) {
+		return prev_workspace_name ? container_find(&root_container,
+				_workspace_by_name, (void *)prev_workspace_name) : NULL;
 	} else {
-		ws = container_find(&root_container, _workspace_by_name,
+		return container_find(&root_container, _workspace_by_name,
 				(void *)name);
 	}
-	free(name_cpy);
-	return ws;
 }
 
 /**

From f7c21451dfa7c4ffdce1307b5856707a0ed40405 Mon Sep 17 00:00:00 2001
From: Ian Fan <ianfan0@gmail.com>
Date: Mon, 6 Aug 2018 12:46:28 +0100
Subject: [PATCH 11/14] commands: fix workspace edge cases

---
 sway/commands/move.c   |  9 +++++++--
 sway/commands/rename.c | 10 ++++++++++
 sway/tree/view.c       |  9 ++++++++-
 3 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/sway/commands/move.c b/sway/commands/move.c
index 500151f7..af3dc538 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -107,8 +107,13 @@ static struct cmd_results *cmd_move_container(struct sway_container *current,
 				strcasecmp(argv[2], "current") == 0) {
 			ws = workspace_by_name(argv[2]);
 		} else if (strcasecmp(argv[2], "back_and_forth") == 0) {
-			if (!(ws = workspace_by_name(argv[0])) && prev_workspace_name) {
-				ws = workspace_create(NULL, prev_workspace_name);
+			if (!(ws = workspace_by_name(argv[2]))) {
+				if (prev_workspace_name) {
+					ws = workspace_create(NULL, prev_workspace_name);
+				} else {
+					return cmd_results_new(CMD_FAILURE, "move",
+							"No workspace was previously active.");
+				}
 			}
 		} else {
 			char *ws_name = NULL;
diff --git a/sway/commands/rename.c b/sway/commands/rename.c
index a380ff9c..c6952bbb 100644
--- a/sway/commands/rename.c
+++ b/sway/commands/rename.c
@@ -61,6 +61,16 @@ struct cmd_results *cmd_rename(int argc, char **argv) {
 	}
 
 	char *new_name = join_args(argv + argn, argc - argn);
+	if (strcasecmp(new_name, "next") == 0 ||
+			strcasecmp(new_name, "prev") == 0 ||
+			strcasecmp(new_name, "next_on_output") == 0 ||
+			strcasecmp(new_name, "prev_on_output") == 0 ||
+			strcasecmp(new_name, "back_and_forth") == 0 ||
+			strcasecmp(new_name, "current") == 0) {
+		free(new_name);
+		return cmd_results_new(CMD_INVALID, "rename",
+				"Cannot use special workspace name '%s'", argv[argn]);
+	}
 	struct sway_container *tmp_workspace = workspace_by_name(new_name);
 	if (tmp_workspace) {
 		free(new_name);
diff --git a/sway/tree/view.c b/sway/tree/view.c
index 48bd7ac0..faaa53a1 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -1,5 +1,6 @@
 #define _POSIX_C_SOURCE 200809L
 #include <stdlib.h>
+#include <strings.h>
 #include <wayland-server.h>
 #include <wlr/render/wlr_renderer.h>
 #include <wlr/types/wlr_buffer.h>
@@ -456,7 +457,13 @@ static struct sway_container *select_workspace(struct sway_view *view) {
 		if (criteria->type == CT_ASSIGN_WORKSPACE) {
 			ws = workspace_by_name(criteria->target);
 			if (!ws) {
-				ws = workspace_create(NULL, criteria->target);
+				if (strcasecmp(criteria->target, "back_and_forth") == 0) {
+					if (prev_workspace_name) {
+						ws = workspace_create(NULL, prev_workspace_name);
+					}
+				} else {
+					ws = workspace_create(NULL, criteria->target);
+				}
 			}
 			break;
 		} else {

From 700941dde8d270b7986bd592fcb42333e7626718 Mon Sep 17 00:00:00 2001
From: emersion <contact@emersion.fr>
Date: Fri, 13 Jul 2018 21:53:56 +0100
Subject: [PATCH 12/14] Listen to server-decoration mode changes

---
 include/sway/decoration.h | 13 +++++++++++++
 include/sway/server.h     | 10 +++++++++-
 sway/decoration.c         | 41 +++++++++++++++++++++++++++++++++++++++
 sway/meson.build          |  5 +++--
 sway/server.c             |  9 ++++++---
 5 files changed, 72 insertions(+), 6 deletions(-)
 create mode 100644 include/sway/decoration.h
 create mode 100644 sway/decoration.c

diff --git a/include/sway/decoration.h b/include/sway/decoration.h
new file mode 100644
index 00000000..c77c04c7
--- /dev/null
+++ b/include/sway/decoration.h
@@ -0,0 +1,13 @@
+#ifndef _SWAY_DECORATION_H
+#define _SWAY_DECORATION_H
+
+#include <wlr/types/wlr_server_decoration.h>
+
+struct sway_server_decoration {
+	struct wlr_server_decoration *wlr_server_decoration;
+
+	struct wl_listener destroy;
+	struct wl_listener mode;
+};
+
+#endif
diff --git a/include/sway/server.h b/include/sway/server.h
index a3782f91..7e73fb4f 100644
--- a/include/sway/server.h
+++ b/include/sway/server.h
@@ -4,12 +4,13 @@
 #include <wayland-server.h>
 #include <wlr/backend.h>
 #include <wlr/backend/session.h>
+#include <wlr/render/wlr_renderer.h>
 #include <wlr/types/wlr_compositor.h>
 #include <wlr/types/wlr_data_device.h>
 #include <wlr/types/wlr_layer_shell.h>
+#include <wlr/types/wlr_server_decoration.h>
 #include <wlr/types/wlr_xdg_shell_v6.h>
 #include <wlr/types/wlr_xdg_shell.h>
-#include <wlr/render/wlr_renderer.h>
 // TODO WLR: make Xwayland optional
 #include "list.h"
 #include "config.h"
@@ -42,11 +43,16 @@ struct sway_server {
 
 	struct wlr_xdg_shell *xdg_shell;
 	struct wl_listener xdg_shell_surface;
+
 #ifdef HAVE_XWAYLAND
 	struct sway_xwayland xwayland;
 	struct wl_listener xwayland_surface;
 	struct wl_listener xwayland_ready;
 #endif
+
+	struct wlr_server_decoration_manager *server_decoration_manager;
+	struct wl_listener server_decoration;
+
 	bool debug_txn_timings;
 
 	list_t *transactions;
@@ -71,4 +77,6 @@ void handle_xdg_shell_surface(struct wl_listener *listener, void *data);
 #ifdef HAVE_XWAYLAND
 void handle_xwayland_surface(struct wl_listener *listener, void *data);
 #endif
+void handle_server_decoration(struct wl_listener *listener, void *data);
+
 #endif
diff --git a/sway/decoration.c b/sway/decoration.c
new file mode 100644
index 00000000..73b3f45d
--- /dev/null
+++ b/sway/decoration.c
@@ -0,0 +1,41 @@
+#include <stdlib.h>
+#include "sway/decoration.h"
+#include "sway/server.h"
+#include "sway/tree/view.h"
+#include "log.h"
+
+static void server_decoration_handle_destroy(struct wl_listener *listener,
+		void *data) {
+	struct sway_server_decoration *deco =
+		wl_container_of(listener, deco, destroy);
+	wl_list_remove(&deco->destroy.link);
+	free(deco);
+}
+
+static void server_decoration_handle_mode(struct wl_listener *listener,
+		void *data) {
+	struct sway_server_decoration *deco =
+		wl_container_of(listener, deco, mode);
+	struct sway_view *view =
+		view_from_wlr_surface(deco->wlr_server_decoration->surface);
+
+	// TODO
+	wlr_log(WLR_ERROR, "%p %d", view, deco->wlr_server_decoration->mode);
+}
+
+void handle_server_decoration(struct wl_listener *listener, void *data) {
+	struct wlr_server_decoration *wlr_deco = data;
+
+	struct sway_server_decoration *deco = calloc(1, sizeof(*deco));
+	if (deco == NULL) {
+		return;
+	}
+
+	deco->wlr_server_decoration = wlr_deco;
+
+	wl_signal_add(&wlr_deco->events.destroy, &deco->destroy);
+	deco->destroy.notify = server_decoration_handle_destroy;
+
+	wl_signal_add(&wlr_deco->events.mode, &deco->mode);
+	deco->mode.notify = server_decoration_handle_mode;
+}
diff --git a/sway/meson.build b/sway/meson.build
index c18fb6e2..2a457270 100644
--- a/sway/meson.build
+++ b/sway/meson.build
@@ -1,13 +1,14 @@
 sway_sources = files(
-	'main.c',
-	'server.c',
 	'commands.c',
 	'config.c',
 	'criteria.c',
 	'debug-tree.c',
+	'decoration.c',
 	'ipc-json.c',
 	'ipc-server.c',
+	'main.c',
 	'security.c',
+	'server.c',
 	'swaynag.c',
 
 	'desktop/desktop.c',
diff --git a/sway/server.c b/sway/server.c
index e8755360..bf6255bc 100644
--- a/sway/server.c
+++ b/sway/server.c
@@ -109,11 +109,14 @@ bool server_init(struct sway_server *server) {
 	}
 #endif
 
-	// TODO: Integration with sway borders
-	struct wlr_server_decoration_manager *deco_manager =
+	server->server_decoration_manager =
 		wlr_server_decoration_manager_create(server->wl_display);
 	wlr_server_decoration_manager_set_default_mode(
-		deco_manager, WLR_SERVER_DECORATION_MANAGER_MODE_SERVER);
+		server->server_decoration_manager,
+		WLR_SERVER_DECORATION_MANAGER_MODE_SERVER);
+	wl_signal_add(&server->server_decoration_manager->events.new_decoration,
+		&server->server_decoration);
+	server->server_decoration.notify = handle_server_decoration;
 
 	wlr_linux_dmabuf_v1_create(server->wl_display, renderer);
 	wlr_export_dmabuf_manager_v1_create(server->wl_display);

From 9d578e0a0f08e053dfc1982e32d9fda172b0087f Mon Sep 17 00:00:00 2001
From: emersion <contact@emersion.fr>
Date: Sun, 29 Jul 2018 18:31:10 +0100
Subject: [PATCH 13/14] Handle views created after decoration mode is sent for
 xdg-shell

---
 include/sway/decoration.h |  4 ++++
 include/sway/server.h     |  1 +
 include/sway/tree/view.h  |  4 ++++
 sway/decoration.c         | 34 ++++++++++++++++++++++++++++++++--
 sway/desktop/xdg_shell.c  | 19 +++++++++++++++++++
 sway/server.c             |  3 +--
 6 files changed, 61 insertions(+), 4 deletions(-)

diff --git a/include/sway/decoration.h b/include/sway/decoration.h
index c77c04c7..7916746e 100644
--- a/include/sway/decoration.h
+++ b/include/sway/decoration.h
@@ -5,9 +5,13 @@
 
 struct sway_server_decoration {
 	struct wlr_server_decoration *wlr_server_decoration;
+	struct wl_list link;
 
 	struct wl_listener destroy;
 	struct wl_listener mode;
 };
 
+struct sway_server_decoration *decoration_from_surface(
+	struct wlr_surface *surface);
+
 #endif
diff --git a/include/sway/server.h b/include/sway/server.h
index 7e73fb4f..b93584b6 100644
--- a/include/sway/server.h
+++ b/include/sway/server.h
@@ -52,6 +52,7 @@ struct sway_server {
 
 	struct wlr_server_decoration_manager *server_decoration_manager;
 	struct wl_listener server_decoration;
+	struct wl_list decorations; // sway_server_decoration::link
 
 	bool debug_txn_timings;
 
diff --git a/include/sway/tree/view.h b/include/sway/tree/view.h
index 37fd02bc..e91d2a20 100644
--- a/include/sway/tree/view.h
+++ b/include/sway/tree/view.h
@@ -118,6 +118,8 @@ struct sway_view {
 struct sway_xdg_shell_v6_view {
 	struct sway_view view;
 
+	enum wlr_server_decoration_manager_mode deco_mode;
+
 	struct wl_listener commit;
 	struct wl_listener request_move;
 	struct wl_listener request_resize;
@@ -134,6 +136,8 @@ struct sway_xdg_shell_v6_view {
 struct sway_xdg_shell_view {
 	struct sway_view view;
 
+	enum wlr_server_decoration_manager_mode deco_mode;
+
 	struct wl_listener commit;
 	struct wl_listener request_move;
 	struct wl_listener request_resize;
diff --git a/sway/decoration.c b/sway/decoration.c
index 73b3f45d..0e3e67ac 100644
--- a/sway/decoration.c
+++ b/sway/decoration.c
@@ -9,6 +9,8 @@ static void server_decoration_handle_destroy(struct wl_listener *listener,
 	struct sway_server_decoration *deco =
 		wl_container_of(listener, deco, destroy);
 	wl_list_remove(&deco->destroy.link);
+	wl_list_remove(&deco->mode.link);
+	wl_list_remove(&deco->link);
 	free(deco);
 }
 
@@ -18,9 +20,24 @@ static void server_decoration_handle_mode(struct wl_listener *listener,
 		wl_container_of(listener, deco, mode);
 	struct sway_view *view =
 		view_from_wlr_surface(deco->wlr_server_decoration->surface);
+	if (view == NULL || view->surface != deco->wlr_server_decoration->surface) {
+		return;
+	}
 
-	// TODO
-	wlr_log(WLR_ERROR, "%p %d", view, deco->wlr_server_decoration->mode);
+	switch (view->type) {
+	case SWAY_VIEW_XDG_SHELL_V6:;
+		struct sway_xdg_shell_v6_view *xdg_shell_v6_view =
+			(struct sway_xdg_shell_v6_view *)view;
+		xdg_shell_v6_view->deco_mode = deco->wlr_server_decoration->mode;
+		break;
+	case SWAY_VIEW_XDG_SHELL:;
+		struct sway_xdg_shell_view *xdg_shell_view =
+			(struct sway_xdg_shell_view *)view;
+		xdg_shell_view->deco_mode = deco->wlr_server_decoration->mode;
+		break;
+	default:
+		break;
+	}
 }
 
 void handle_server_decoration(struct wl_listener *listener, void *data) {
@@ -38,4 +55,17 @@ void handle_server_decoration(struct wl_listener *listener, void *data) {
 
 	wl_signal_add(&wlr_deco->events.mode, &deco->mode);
 	deco->mode.notify = server_decoration_handle_mode;
+
+	wl_list_insert(&server.decorations, &deco->link);
+}
+
+struct sway_server_decoration *decoration_from_surface(
+		struct wlr_surface *surface) {
+	struct sway_server_decoration *deco;
+	wl_list_for_each(deco, &server.decorations, link) {
+		if (deco->wlr_server_decoration->surface == surface) {
+			return deco;
+		}
+	}
+	return NULL;
 }
diff --git a/sway/desktop/xdg_shell.c b/sway/desktop/xdg_shell.c
index b364663d..3b73f99c 100644
--- a/sway/desktop/xdg_shell.c
+++ b/sway/desktop/xdg_shell.c
@@ -6,6 +6,7 @@
 #include <wlr/types/wlr_xdg_shell.h>
 #include <wlr/util/edges.h>
 #include "log.h"
+#include "sway/decoration.h"
 #include "sway/input/input-manager.h"
 #include "sway/input/seat.h"
 #include "sway/server.h"
@@ -170,6 +171,15 @@ static bool wants_floating(struct sway_view *view) {
 		|| toplevel->parent;
 }
 
+static bool has_client_side_decorations(struct sway_view *view) {
+	struct sway_xdg_shell_view *xdg_shell_view =
+		xdg_shell_view_from_view(view);
+	if (xdg_shell_view == NULL) {
+		return true;
+	}
+	return xdg_shell_view->deco_mode != WLR_SERVER_DECORATION_MANAGER_MODE_SERVER;
+}
+
 static void for_each_surface(struct sway_view *view,
 		wlr_surface_iterator_func_t iterator, void *user_data) {
 	if (xdg_shell_view_from_view(view) == NULL) {
@@ -226,6 +236,7 @@ static const struct sway_view_impl view_impl = {
 	.set_tiled = set_tiled,
 	.set_fullscreen = set_fullscreen,
 	.wants_floating = wants_floating,
+	.has_client_side_decorations = has_client_side_decorations,
 	.for_each_surface = for_each_surface,
 	.for_each_popup = for_each_popup,
 	.close = _close,
@@ -357,6 +368,14 @@ static void handle_map(struct wl_listener *listener, void *data) {
 		view->natural_height = view->wlr_xdg_surface->surface->current.height;
 	}
 
+	struct sway_server_decoration *deco =
+		decoration_from_surface(xdg_surface->surface);
+	if (deco != NULL) {
+		xdg_shell_view->deco_mode = deco->wlr_server_decoration->mode;
+	} else {
+		xdg_shell_view->deco_mode = WLR_SERVER_DECORATION_MANAGER_MODE_CLIENT;
+	}
+
 	view_map(view, view->wlr_xdg_surface->surface);
 
 	if (xdg_surface->toplevel->client_pending.fullscreen) {
diff --git a/sway/server.c b/sway/server.c
index bf6255bc..e8dc63be 100644
--- a/sway/server.c
+++ b/sway/server.c
@@ -19,7 +19,6 @@
 #include <wlr/types/wlr_xcursor_manager.h>
 #include <wlr/types/wlr_xdg_output.h>
 #include <wlr/util/log.h>
-// TODO WLR: make Xwayland optional
 #include "list.h"
 #include "sway/config.h"
 #include "sway/desktop/idle_inhibit_v1.h"
@@ -85,7 +84,6 @@ bool server_init(struct sway_server *server) {
 		&server->xdg_shell_surface);
 	server->xdg_shell_surface.notify = handle_xdg_shell_surface;
 
-	// TODO make xwayland optional
 #ifdef HAVE_XWAYLAND
 	server->xwayland.wlr_xwayland =
 		wlr_xwayland_create(server->wl_display, server->compositor, true);
@@ -117,6 +115,7 @@ bool server_init(struct sway_server *server) {
 	wl_signal_add(&server->server_decoration_manager->events.new_decoration,
 		&server->server_decoration);
 	server->server_decoration.notify = handle_server_decoration;
+	wl_list_init(&server->decorations);
 
 	wlr_linux_dmabuf_v1_create(server->wl_display, renderer);
 	wlr_export_dmabuf_manager_v1_create(server->wl_display);

From d2ac48f9206e9962ab47f337f824ce7f69ffb9c1 Mon Sep 17 00:00:00 2001
From: emersion <contact@emersion.fr>
Date: Mon, 6 Aug 2018 15:28:33 +0100
Subject: [PATCH 14/14] Handle views created after decoration mode is sent for
 xdg-shell-v6

---
 sway/desktop/xdg_shell_v6.c | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/sway/desktop/xdg_shell_v6.c b/sway/desktop/xdg_shell_v6.c
index ffea03ad..a947fb35 100644
--- a/sway/desktop/xdg_shell_v6.c
+++ b/sway/desktop/xdg_shell_v6.c
@@ -4,14 +4,15 @@
 #include <stdlib.h>
 #include <wayland-server.h>
 #include <wlr/types/wlr_xdg_shell_v6.h>
+#include "log.h"
+#include "sway/decoration.h"
+#include "sway/input/input-manager.h"
+#include "sway/input/seat.h"
 #include "sway/server.h"
 #include "sway/tree/arrange.h"
 #include "sway/tree/container.h"
 #include "sway/tree/layout.h"
 #include "sway/tree/view.h"
-#include "sway/input/seat.h"
-#include "sway/input/input-manager.h"
-#include "log.h"
 
 static const struct sway_view_child_impl popup_impl;
 
@@ -166,6 +167,15 @@ static bool wants_floating(struct sway_view *view) {
 		|| toplevel->parent;
 }
 
+static bool has_client_side_decorations(struct sway_view *view) {
+	struct sway_xdg_shell_v6_view *xdg_shell_v6_view =
+		xdg_shell_v6_view_from_view(view);
+	if (xdg_shell_v6_view == NULL) {
+		return true;
+	}
+	return xdg_shell_v6_view->deco_mode != WLR_SERVER_DECORATION_MANAGER_MODE_SERVER;
+}
+
 static void for_each_surface(struct sway_view *view,
 		wlr_surface_iterator_func_t iterator, void *user_data) {
 	if (xdg_shell_v6_view_from_view(view) == NULL) {
@@ -223,6 +233,7 @@ static const struct sway_view_impl view_impl = {
 	.set_tiled = set_tiled,
 	.set_fullscreen = set_fullscreen,
 	.wants_floating = wants_floating,
+	.has_client_side_decorations = has_client_side_decorations,
 	.for_each_surface = for_each_surface,
 	.for_each_popup = for_each_popup,
 	.close = _close,
@@ -353,6 +364,14 @@ static void handle_map(struct wl_listener *listener, void *data) {
 		view->natural_height = view->wlr_xdg_surface_v6->surface->current.height;
 	}
 
+	struct sway_server_decoration *deco =
+		decoration_from_surface(xdg_surface->surface);
+	if (deco != NULL) {
+		xdg_shell_v6_view->deco_mode = deco->wlr_server_decoration->mode;
+	} else {
+		xdg_shell_v6_view->deco_mode = WLR_SERVER_DECORATION_MANAGER_MODE_CLIENT;
+	}
+
 	view_map(view, view->wlr_xdg_surface_v6->surface);
 
 	if (xdg_surface->toplevel->client_pending.fullscreen) {